Update the signed build lab version of VS + suppress 6385 in fmt.

Resolves:

```
FAILED: _deps/fmt-build/CMakeFiles/fmt.dir/src/format.cc.obj
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1442~1.344\bin\HostX64\x64\cl.exe  /nologo /TP  -ID:\a\_work\1\b\amd64\_deps\fmt-src\include /DWIN32 /D_WINDOWS /EHsc /EHsc -FC -permissive- -utf-8 /guard:cf /W4 /sdl -analyze -analyze:stacksize 39000 -wd6553 /WX /wd4834 /wd6031 /wd6294 /wd6240 /wd6326 /O2 /Ob2 /DNDEBUG /Zi /GL -std:c++17 -MT /utf-8 /showIncludes /Fo_deps\fmt-build\CMakeFiles\fmt.dir\src\format.cc.obj /Fdfmt.pdb /FS -c D:\a\_work\1\b\amd64\_deps\fmt-src\src\format.cc
D:\a\_work\1\b\amd64\_deps\fmt-src\include\fmt\format-inl.h(308): error C2220: the following warning is treated as an error
D:\a\_work\1\b\amd64\_deps\fmt-src\include\fmt\format-inl.h(307) : warning C6385: Reading invalid data from 'pow10_significands'.: Lines: 278, 280, 307
D:\a\_work\1\b\amd64\_deps\fmt-src\include\fmt\format-inl.h(307) : warning C6385: Reading invalid data from 'pow10_significands'.: Lines: 278, 280, 307
[36/158] Building CXX object _deps\fmt-build\CMakeFiles\fmt.dir\src\os.cc.obj
```

happening in the build lab.
This commit is contained in:
Billy Robert O'Neal III committed 2026-04-05 23:52:56 -07:00
1 parent 61719d8268
commit 98b088f896
2 files changed
+9 -5

No files matched your search

+5 -5
View File
@@ -45,7 +45,7 @@ extends:
- name: VCPKG_INITIAL_BASE_VERSION
value: ${{parameters.VcpkgBaseVersionOverride}}
pool:
name: 'VSEngSS-MicroBuild2022-1ES'
name: 'VSEng-MicroBuildVSStable'
templateContext:
sdl:
codeql:
@@ -313,7 +313,7 @@ extends:
- muslc_build
- glibc_arm64_build
pool:
name: 'VSEngSS-MicroBuild2022-1ES'
name: 'VSEng-MicroBuildVSStable'
variables:
VCPKG_BASE_VERSION: $[ dependencies.arch_independent.outputs['versions.VCPKG_BASE_VERSION'] ]
VCPKG_FULL_VERSION: $[ dependencies.arch_independent.outputs['versions.VCPKG_FULL_VERSION'] ]
@@ -380,7 +380,7 @@ extends:
inputs:
failOnStderr: true
script: |
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 -host_arch=amd64
call "C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 -host_arch=amd64
cmake.exe --version
set X_VCPKG_ASSET_SOURCES=x-script,$(Build.BinariesDirectory)\Microsoft.Build.Vcpkg\trt\TerrapinRetrievalTool.exe -b https://vcpkg.storage.devpackages.microsoft.io/artifacts/ -a true -u Environment -p {url} -s {sha512} -d {dst};x-block-origin
cmake.exe -G Ninja -DCMAKE_TOOLCHAIN_FILE="$(Build.BinariesDirectory)\Microsoft.Build.Vcpkg\tools\scripts\buildsystems\vcpkg.cmake" -DVCPKG_TARGET_TRIPLET=x64-windows-static-release -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DVCPKG_DEVELOPMENT_WARNINGS=ON -DVCPKG_WARNINGS_AS_ERRORS=ON -DVCPKG_BUILD_FUZZING=OFF -DVCPKG_BUILD_TLS12_DOWNLOADER=ON -DVCPKG_EMBED_GIT_SHA=ON -DVCPKG_OFFICIAL_BUILD=ON "-DVCPKG_FMT_URL=$(fmt-tarball-url)" "-DVCPKG_CMAKERC_URL=$(cmakerc-tarball-url)" "-DVCPKG_BASE_VERSION=$(VCPKG_BASE_VERSION)" "-DVCPKG_VERSION=$(Build.SourceVersion)" "-DVCPKG_STANDALONE_BUNDLE_SHA=$(VCPKG_STANDALONE_BUNDLE_SHA)" "-DVCPKG_ARTIFACTS_SHA=$(VCPKG_ARTIFACTS_SHA)" -B "$(Build.BinariesDirectory)\amd64" 2>&1
@@ -390,7 +390,7 @@ extends:
inputs:
failOnStderr: true
script: |
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=arm64 -host_arch=amd64
call "C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=arm64 -host_arch=amd64
cmake.exe --version
set X_VCPKG_ASSET_SOURCES=x-script,$(Build.BinariesDirectory)\Microsoft.Build.Vcpkg\trt\TerrapinRetrievalTool.exe -b https://vcpkg.storage.devpackages.microsoft.io/artifacts/ -a true -u Environment -p {url} -s {sha512} -d {dst};x-block-origin
cmake.exe -G Ninja -DCMAKE_TOOLCHAIN_FILE="$(Build.BinariesDirectory)\Microsoft.Build.Vcpkg\tools\scripts\buildsystems\vcpkg.cmake" -DVCPKG_TARGET_TRIPLET=arm64-windows-static-release -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DVCPKG_DEVELOPMENT_WARNINGS=ON -DVCPKG_WARNINGS_AS_ERRORS=ON -DVCPKG_BUILD_FUZZING=OFF -DVCPKG_BUILD_TLS12_DOWNLOADER=ON -DVCPKG_EMBED_GIT_SHA=ON -DVCPKG_OFFICIAL_BUILD=ON -DVCPKG_PDB_SUFFIX="-arm64" "-DVCPKG_FMT_URL=$(fmt-tarball-url)" "-DVCPKG_CMAKERC_URL=$(cmakerc-tarball-url)" "-DVCPKG_BASE_VERSION=$(VCPKG_BASE_VERSION)" "-DVCPKG_VERSION=$(Build.SourceVersion)" "-DVCPKG_STANDALONE_BUNDLE_SHA=$(VCPKG_STANDALONE_BUNDLE_SHA)" "-DVCPKG_ARTIFACTS_SHA=$(VCPKG_ARTIFACTS_SHA)" -B "$(Build.BinariesDirectory)\arm64" 2>&1
@@ -539,7 +539,7 @@ extends:
- arch_independent
- windows_and_sign
pool:
name: 'VSEngSS-MicroBuild2022-1ES'
name: 'VSEng-MicroBuildVSStable'
variables:
VCPKG_BASE_VERSION: $[ dependencies.arch_independent.outputs['versions.VCPKG_BASE_VERSION'] ]
templateContext:
+4
View File
@@ -31,6 +31,10 @@ if(MSVC AND VCPKG_DEVELOPMENT_WARNINGS AND NOT (CMAKE_CXX_COMPILER_ID MATCHES "A
# This one is guarded by an assert
# fmt\os.h(377): warning C6326: Potential comparison of a constant with another constant.
string(APPEND CMAKE_CXX_FLAGS " /wd6326")
# fmt\format-inl.h(307): warning C6385: Reading invalid data from 'pow10_significands'.
# This reproduced in the Windows signing configuration under Release + /analyze; test in
# release mode before removing this suppression in the future.
string(APPEND CMAKE_CXX_FLAGS " /wd6385")
endif()
include(FetchContent)