aphrody-labs/PowerShell
1
0 Fork 0
mirror of https://github.com/aphrody-labs/PowerShell.git synced 2026-10-17 04:36:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
59 Commits 44 Branches 235 Tags
d7355a0572f86cae3bd2374b1e0e997cafe9b645
Commit Graph
59 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Aaron d7355a0572 implemented suggested changes based off of feedback 2015-08-14 12:26:15 -07:00
Aaron 4f62559eaf Merge remote-tracking branch 'origin/develop' into dev/8-getcpinfo 2015-08-14 11:34:48 -07:00
Aaron 53e7c11e69 Added changes based of feedback from Peter 2015-08-14 09:26:45 -07:00
Andrew Schwartzmeyer d298302e8c Use libicu properly in tests 2015-08-13 21:34:59 -07:00
Andrew Schwartzmeyer 60a9a360a1 Use libicu properly for UTF-16 conversion 
- No more messy calculations
- Only one include, not four
- No resizing
- No memcpy
- Faster because of fromUTF8()
 2015-08-13 21:27:08 -07:00
Andrew Schwartzmeyer 70a163e061 Use known size instead of calculation 2015-08-13 20:32:30 -07:00
Andrew Schwartzmeyer 674ca43046 Use just LOGIN_NAME_MAX 
The +1 is unnecessary since LOGIN_NAME_MAX includes null.
 2015-08-13 20:32:30 -07:00
Andrew Schwartzmeyer db7117bd47 Use length() instead of size() 
To be consistent with everything else.
 2015-08-13 20:32:30 -07:00
Andrew Schwartzmeyer fc8f5d18c4 Use 0 instead of '\0' 
To be consistent with tests
 2015-08-13 20:32:30 -07:00
Andrew Schwartzmeyer bb67bfaae7 Remove std::string utf8 
Not used consistently. Use in-place for comparison.
 2015-08-13 17:53:28 -07:00
Andrew Schwartzmeyer 46677d776b Return FALSE instead of 0 2015-08-13 17:44:05 -07:00
Aaron 1b537f0c8f Changed based of feedback 2015-08-13 10:48:38 -07:00
Andrew Schwartzmeyer 9a42b894f2 Convert to Allman style with 4-space indentation 2015-08-07 18:43:58 -07:00
Andrew Schwartzmeyer da1e65cfaf Add -Wall to CMAKE_CXX_FLAGS 2015-08-07 12:07:19 -07:00
Andrew Schwartzmeyer 665f8f1e87 Map getlogin_r()'s ERANGE to ERROR_GEN_FAILURE 
ERROR_INSUFFICIENT_BUFFER should never occur here and would be a
misleading error for the user.
 2015-08-07 12:05:07 -07:00
Andrew Schwartzmeyer f8e9dfde8c Fix style issues 
- Use Doxygen style comments (with better comments)
- Use `type* ident` instead of `type *ident`
- Start { on new lines
- Use TRUE/FALSE from PAL.H
 2015-08-07 12:03:31 -07:00
Andrew Schwartzmeyer c8f9777481 Clean up CMakeLists 2015-08-06 17:03:53 -07:00
Andrew Schwartzmeyer b379fb4a6b Rename to GetUserNameW since it is Unicode 2015-08-06 16:28:29 -07:00
Aaron 316cabbdcf Got rid of tests for UTF7, added error checking, adding test to check for null paramater for codepage 2015-08-06 10:16:13 -07:00
Aaron 8bf19f7144 updates to CMakeFile.txt 2015-08-05 13:28:12 -07:00
Andrew Schwartzmeyer 447896aede Use WCHAR sizes instead of CHAR sizes 
Such that lpnSize is the length (number of UTF-16 characters, including
null) of the username. Must be multiplied by sizeof(char16_t) for bytes.
 2015-08-04 18:31:54 -07:00
Andrew Schwartzmeyer e64c8961c9 Update GetUserName tests 
Note that these fail when run in a Docker container because a) the
current container's locale is not completely set, and b) getlogin()
returns null with ENOENT since /var/run/utmp is being mapped to the
host, and thus denied access from within the container.

The container needs the locale set and its own /run/utmp, see
https://lists.linuxcontainers.org/pipermail/lxc-users/2011-July/002374.html
 2015-08-04 14:16:57 -07:00
Andrew Schwartzmeyer d60bfe0376 Use icu for Unicode conversion and fix lpnSize 
A careful reading of the GetUserName documentation and Windows Data
Types says that lpnSize is "the number of TCHARs copied to the
buffer...including the terminating null character," and a TCHAR in this
environment is a CHAR because we assume UNICODE is always defined for
CoreCLR. A CHAR is a byte. So lpSize is number of bytes, not number of
UTF-16 characters as we previously believed.
 2015-08-04 14:16:49 -07:00
Andrew Schwartzmeyer 6ddb39e337 Link ps against icu instead of scxcore 
Remove scxcore library from CMake
 2015-08-04 14:14:07 -07:00
Andrew Schwartzmeyer 0c9fb0d01b Rename userName in test to expectedUsername 
To clarify that it is for comparison; not the result of GetUserName.
 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer b076850012 Refactor setting of lpnSize when buffer size is insufficient 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer 2a2c1d9236 Remove unnecessary static qualifier from const string 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer 0592a37395 Use std::string instead of C99 dynamic array 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer 9426e9c455 Use LOGIN_NAME_MAX instead of L_cuserid 
Since L_cuserid is only for cuserid, not getlogin_r

Unit test for L_cuserid removed because the macro may not be available
on all platforms.
 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer cbee353d0d Add more unit test coverage for GetUserName 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer 4a2c1c5a95 Set lpnSize when insufficient 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer 0f07a65f50 Use test fixture in GetUserName unit tests 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer e8cb7e24fe Use L_cuserid instead of 64 and given lpnSize 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer 3ab3408378 Factor out using directives 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer 6699091f7b Change global to local static const 
To avoid polluting the global namespace without using a namespace.
 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer 41a00d9279 Clarify lpBuffer layout in GetUserName unit test 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer 3ac74ab849 Convert get_login_r to UTF-16 and return 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer 6481f0336d Check for invalid parameters in GetUserName 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer a18a5912ab Explain GetUserName signature 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer ff0b43015b Test UTF-16 output of GetUserName 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer 8dbe788284 Link scxcore to ps and include headers 2015-08-03 13:00:34 -07:00
Andrew Schwartzmeyer f8eedc7210 Add unit test for GetUserName 2015-08-03 12:58:59 -07:00
Andrew Schwartzmeyer b80da9ab4d Use getlogin_r() in GetUserName and map errno 2015-08-03 12:53:39 -07:00
Andrew Schwartzmeyer f676c77a8e Check locale in GetUserName 2015-08-03 12:53:39 -07:00
Andrew Schwartzmeyer 4404e03613 Update GetUserName signature 2015-08-03 12:53:39 -07:00
Peter Honeder 8eeb24ece9 added hostutil.h, added tests for hostutil, added more cmdline options to PS host 2015-07-30 16:53:35 +02:00
Peter Honeder ff2ceeceb7 added interpreting the verbose option 2015-07-29 18:12:31 +02:00
Peter Honeder ea76b7e8fd fixed string termination issue, added verbose mode 2015-07-28 18:49:32 +02:00
Peter Honeder c0414f8fc4 cleaned up implementation, added command line parsing and standardized managed interface for cmdline hosts 2015-07-28 18:28:09 +02:00
Peter Honeder ba45c8f076 renamed function pointer type, changed code to call UnmanagedMain 2015-07-27 18:40:33 +02:00