mirror of
https://github.com/aphrody-labs/PowerShell.git
synced 2026-10-17 12:45:47 +00:00
Change Newtonsoft deserializing bug comment to link to the new issue (#8377)
This is a follow up to reverted PR #8346. I removed a workaround that was used to avoid [a Newtonsoft.Json bug](https://github.com/JamesNK/Newtonsoft.Json/issues/1321) that caused some incomplete json array input to successfully be deserialized. This bug being fixed, I thought the workaround was unnecessary, but after the merge some feature tests started to fail (which I did not run prior to merging). It was discovered that the workaround is still needed because while the first Newtonsoft.Json bug was fixed, some cases of incomplete json array input still behave unexpectedly, namely json input `[`. This PR is just to update the comment explaining the workaround so it links to the newly created issue [here](https://github.com/JamesNK/Newtonsoft.Json/issues/1930).
This commit is contained in:
1 parent
45f10a079c
commit
d150871af2
1 file changed
+1
-1
@@ -60,7 +60,7 @@ namespace Microsoft.PowerShell.Commands
|
||||
try
|
||||
{
|
||||
// JsonConvert.DeserializeObject does not throw an exception when an invalid Json array is passed.
|
||||
// This issue is being tracked by https://github.com/JamesNK/Newtonsoft.Json/issues/1321.
|
||||
// This issue is being tracked by https://github.com/JamesNK/Newtonsoft.Json/issues/1930.
|
||||
// To work around this, we need to identify when input is a Json array, and then try to parse it via JArray.Parse().
|
||||
|
||||
// If input starts with '[' (ignoring white spaces).
|
||||
|
||||
Reference in new issue
Block a user