aphrody-labs/PowerShell
1
0 Fork 0
mirror of https://github.com/aphrody-labs/PowerShell.git synced 2026-10-17 12:45:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Ensure the SSHClientSessionTransportManager stream writer and reader fields are cleared after dispose. (#7746)

Browse Source 
Fix possible race conditions accessing the fields during CloseConnection.
This commit is contained in:
Dan Travison authored and Travis Plunk committed 2018-09-10 13:06:05 -07:00
1 parent 89278290d9
commit ccee14dc65
1 file changed
+4 -5
Download Patch File Download Diff File Expand all files Collapse all files
src/System.Management.Automation/engine/remoting/fanin/OutOfProcTransportManager.cs
+4 -5
View File
@@ -1503,20 +1503,19 @@ namespace System.Management.Automation.Remoting.Client
private void CloseConnection()
{
var stdInWriter = _stdInWriter;
var stdInWriter = Interlocked.Exchange(ref _stdInWriter, null);
if (stdInWriter != null) { stdInWriter.Dispose(); }
var stdOutReader = _stdOutReader;
var stdOutReader = Interlocked.Exchange(ref _stdOutReader, null);
if (stdOutReader != null) { stdOutReader.Dispose(); }
var stdErrReader = _stdErrReader;
var stdErrReader = Interlocked.Exchange(ref _stdErrReader, null);
if (stdErrReader != null) { stdErrReader.Dispose(); }
// The CloseConnection() method can be called multiple times from multiple places.
// Set the _sshProcessId to zero here so that we go through the work of finding
// and terminating the SSH process just once.
var sshProcessId = _sshProcessId;
_sshProcessId = 0;
var sshProcessId = Interlocked.Exchange(ref _sshProcessId, 0);
if (sshProcessId != 0)
{
try