aphrody-labs/PowerShell
1
0 Fork 0
mirror of https://github.com/aphrody-labs/PowerShell.git synced 2026-10-13 21:32:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve remote prompt handling for PSCredential and SecureString arrays (#28007)

Browse Source
This commit is contained in:
Anam Navied authored and GitHub committed 2026-09-11 15:24:07 -07:00
1 parent 9f7b30680d
commit a71ba38db7
2 files changed
+14 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs
+11 -2
View File
@@ -666,12 +666,21 @@ namespace System.Management.Automation.Internal.Host
internal static bool IsSecuritySensitiveType(string typeName)
{
if (typeName.Equals(nameof(PSCredential), StringComparison.OrdinalIgnoreCase))
string effectiveName = typeName;
int suffixIndex = effectiveName.IndexOfAny(new char[] { '[', ',' });
if (suffixIndex >= 0)
{
effectiveName = effectiveName.Substring(0, suffixIndex);
}
if (effectiveName.Equals(nameof(PSCredential), StringComparison.OrdinalIgnoreCase) ||
effectiveName.Equals(typeof(PSCredential).FullName, StringComparison.OrdinalIgnoreCase))
{
return true;
}
if (typeName.Equals(nameof(SecureString), StringComparison.OrdinalIgnoreCase))
if (effectiveName.Equals(nameof(SecureString), StringComparison.OrdinalIgnoreCase) ||
effectiveName.Equals(typeof(SecureString).FullName, StringComparison.OrdinalIgnoreCase))
{
return true;
}
src/System.Management.Automation/engine/remoting/common/WireDataFormat/RemoteHost.cs
+3 -2
View File
@@ -379,12 +379,13 @@ namespace System.Management.Automation.Remoting
Type fieldType = InternalHostUserInterface.GetFieldType(fieldDesc);
if (fieldType != null)
{
if (fieldType == typeof(PSCredential))
Type effectiveType = fieldType.IsArray ? fieldType.GetElementType() : fieldType;
if (effectiveType == typeof(PSCredential))
{
havePSCredential = true;
fieldDesc.ModifiedByRemotingProtocol = true;
}
else if (fieldType == typeof(System.Security.SecureString))
else if (effectiveType == typeof(System.Security.SecureString))
{
prerequisiteCalls.Add(ConstructWarningMessageForSecureString(
computerName, RemotingErrorIdStrings.RemoteHostPromptSecureStringPrompt));