aphrody-labs/oxc
1
0 Fork 0
mirror of https://github.com/aphrody-labs/oxc.git synced 2026-10-15 14:49:36 +00:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity

perf(minifier): update expressions in place in merge_import_export (#27226)

Browse Source 
this is a refactor that lets us avoid creation of temporary empty
statement and temporary dummy expr
This commit is contained in:
Armano authored and GitHub committed 2026-09-30 15:23:11 +01:00
1 parent adb1139e64
commit 466ef10f3e
2 files changed
+52 -59
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

crates/oxc_minifier/src/peephole/minimize_statements.rs
+51 -58
View File
@@ -430,80 +430,73 @@ impl<'a> PeepholeOptimizations {
let Statement::ExportNamedDeclaration(mut export_decl) = old_export else {
unreachable!();
};
ctx.replace_statement_with(stmts.get_mut(import_index).unwrap(), |old_import, ctx| {
ctx.drop_statement(&old_import);
let old_import = std::mem::replace(
stmts.get_mut(import_index).unwrap(),
Statement::new_empty_statement(SPAN, ctx),
);
ctx.drop_statement(&old_import);
let Statement::ImportDeclaration(import_decl) = old_import else {
unreachable!();
};
let ImportDeclaration {
specifiers: Some(mut import_specifiers),
source,
with_clause,
..
} = import_decl.unbox()
else {
unreachable!();
};
let Statement::ImportDeclaration(import_decl) = old_import else {
unreachable!();
};
let ImportDeclaration {
specifiers: Some(mut import_specifiers),
source,
with_clause,
..
} = import_decl.unbox()
else {
unreachable!();
};
let is_namespace_import = matches!(
import_specifiers.as_slice(),
[ImportDeclarationSpecifier::ImportNamespaceSpecifier(_)]
);
if is_namespace_import {
let exported = export_decl.specifiers.pop().unwrap().exported;
ctx.replace_statement(
stmts.get_mut(import_index).unwrap(),
Statement::new_export_all_declaration(
let is_namespace_import = matches!(
import_specifiers.as_slice(),
[ImportDeclarationSpecifier::ImportNamespaceSpecifier(_)]
);
if is_namespace_import {
let exported = export_decl.specifiers.pop().unwrap().exported;
return Statement::new_export_all_declaration(
export_decl.span,
Some(exported),
source,
with_clause,
export_decl.export_kind,
ctx,
),
);
continue;
}
);
}
for export_specifier in &mut export_decl.specifiers {
let ModuleExportName::IdentifierReference(id) = &export_specifier.local else {
unreachable!();
};
let symbol_id = ctx.scoping().get_reference(id.reference_id()).symbol_id().unwrap();
let import_specifier = import_specifiers
.iter_mut()
.find(|import_specifier| import_specifier.symbol_id() == symbol_id)
.unwrap();
export_specifier.local = match import_specifier {
ImportDeclarationSpecifier::ImportSpecifier(import_specifier) => {
import_specifier.imported.clone_in(ctx.allocator())
}
ImportDeclarationSpecifier::ImportDefaultSpecifier(import_default) => {
ModuleExportName::IdentifierName(IdentifierName::new(
import_default.span,
"default",
ctx,
))
}
ImportDeclarationSpecifier::ImportNamespaceSpecifier(_) => unreachable!(),
};
}
for export_specifier in &mut export_decl.specifiers {
let ModuleExportName::IdentifierReference(id) = &export_specifier.local else {
unreachable!();
};
let symbol_id =
ctx.scoping().get_reference(id.reference_id()).symbol_id().unwrap();
let import_specifier = import_specifiers
.iter_mut()
.find(|import_specifier| import_specifier.symbol_id() == symbol_id)
.unwrap();
export_specifier.local = match import_specifier {
ImportDeclarationSpecifier::ImportSpecifier(import_specifier) => {
import_specifier.imported.clone_in(ctx.allocator())
}
ImportDeclarationSpecifier::ImportDefaultSpecifier(import_default) => {
ModuleExportName::IdentifierName(IdentifierName::new(
import_default.span,
"default",
ctx,
))
}
ImportDeclarationSpecifier::ImportNamespaceSpecifier(_) => unreachable!(),
};
}
ctx.replace_statement(
stmts.get_mut(import_index).unwrap(),
let export_decl = export_decl.unbox();
Statement::new_export_from_declaration(
export_decl.span,
export_decl.specifiers.take_in(ctx),
export_decl.specifiers,
source,
export_decl.export_kind,
with_clause,
ctx,
),
);
)
});
}
}
tasks/track_memory_allocations/allocs_minifier.yaml
+1 -1
View File
@@ -71,6 +71,6 @@ kitchen-sink.tsx:
sys deallocs: 1854
sys alloc bytes: 5304252 # 5.30 MB
sys peak growth: 3707425 # 3.71 MB
arena allocs: 31108
arena allocs: 31107
arena reallocs: 3012
arena size: 8444928 # 8.44 MB