Christoph Reiter 3ea87a506e Cygwin: console: Avoid deadlock with app execution aliases
Calling `winget.exe` through its app execution alias from an interactive
MSYS2 shell can leave the shell hanging after `winget.exe` exits. This
affects all app execution aliases, not only `winget.exe`.

App execution alias handling was introduced in 0631c6644e (Cygwin: Treat
Windows Store's "app execution aliases" as symbolic links, 2021-03-22),
and 6c3d26961d (Cygwin: termios: Handle app execution alias in
is_console_app(), 2025-12-10) taught `is_console_app()` to follow
aliases using another `path_conv`, which allocates cygheap memory.

618eb90fc2 (Cygwin: console: Fix undesired mode change at exit of
non-cygwin apps, 2026-09-19) added a second `is_console_app()` call from
`wait_for_resume_if_necessary()`. Unfortunately, at that point,
`child_info_spawn::worker()` already holds the non-recursive
`cygheap_protect`, so following an alias tries to acquire the same lock
recursively and deadlocks.

Let's avoid running `is_console_app()` under that lock by instead
classifying the executable _once_, in `spawn_worker::setup()`, before
acquiring the cygheap lock, then cache and reuse the result for both PTY
setup and the post-resume wait.

Addresses: https://github.com/msys2/msys2-runtime/issues/372
Fixes: 618eb90fc2 (Cygwin: console: Fix undesired mode change at exit
 of non-cygwin apps, 2026-09-19)
Signed-off-by: Christoph Reiter <reiter.christoph@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
2026-09-28 11:31:13 +02:00
2023-05-30 13:55:09 -04:00
2021-11-10 20:14:00 -05:00
2015-03-09 20:53:11 +01:00
2016-03-22 10:25:20 +01:00
2016-03-22 10:25:20 +01:00
2021-02-24 11:03:28 +01:00
2016-03-22 10:25:20 +01:00
2016-03-22 10:25:20 +01:00
2016-03-22 10:25:20 +01:00
2010-01-09 21:11:32 +00:00
2014-02-05 13:17:47 +00:00
2010-01-09 21:11:32 +00:00
2010-01-09 21:11:32 +00:00
2016-06-23 15:54:55 -04:00
1999-05-03 07:29:06 +00:00
2016-03-22 10:25:20 +01:00
2016-03-22 10:25:20 +01:00
1999-05-03 07:29:06 +00:00
2016-03-22 10:25:20 +01:00

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.
S
Description
No description provided
Readme GPL-2.0
112 MiB
0 Stars 1 Watchers 0 Forks
Languages
C 60.7%
Makefile 19.4%
C++ 10.5%
Assembly 4.8%
Linker Script 1.2%
Other 3.2%