* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
To reliably test later HiDPI fixes, it is important to enable
HiDPI-rendering of pixmaps in test applications in the first place.
Tests without pixmaps have not been changed, the flag will be set by
default in Qt 6 anyway.
Test Plan:
`QT_SCALE_FACTOR=1.7 ./bin/kxmlguiwindowtest` does not show pixelated
icons anymore, except in places needing individual fixes (e.g. arrows in
"Configure Keyboard Shortcuts" dialog).
Nicolas Fella