mirror of
https://github.com/aphrody-labs/cef.git
synced 2026-10-14 13:19:26 +00:00
Marshall Greenblatt
33624e6bc2
- Windows SDK 10.0.28000.2270 is now required - CefRegisterExtension is deprecated due to https://crbug.com/40347662
65 lines
3.0 KiB
Diff
65 lines
3.0 KiB
Diff
diff --git build/toolchain/win/setup_toolchain.py build/toolchain/win/setup_toolchain.py
|
|
index e7651ec9f8b538d0eca24b74fef7cd40771da72e..ae80221a4aa3e4e7bd20d28a34a3e3f008f7e2e0 100644
|
|
--- build/toolchain/win/setup_toolchain.py
|
|
+++ build/toolchain/win/setup_toolchain.py
|
|
@@ -181,18 +181,20 @@ def _LoadToolchainEnv(cpu, toolchain_root, sdk_dir, target_store):
|
|
del os.environ['LIB']
|
|
if 'LIBPATH' in os.environ:
|
|
del os.environ['LIBPATH']
|
|
- other_path = os.path.normpath(
|
|
+ script_path = os.path.normpath(
|
|
os.path.join(
|
|
os.environ['GYP_MSVS_OVERRIDE_PATH'],
|
|
'VC/Auxiliary/Build/vcvarsall.bat',
|
|
)
|
|
)
|
|
- if not os.path.exists(other_path):
|
|
- raise Exception(
|
|
- '%s is missing - make sure VC++ tools are installed.'
|
|
- % script_path
|
|
- )
|
|
- script_path = other_path
|
|
+ if not os.path.exists(script_path):
|
|
+ # Compiler environment variables must already be specified.
|
|
+ variables = []
|
|
+ for k in sorted(os.environ.keys()):
|
|
+ variables.append('%s=%s' % (str(k), str(os.environ[k])))
|
|
+ variables = '\n'.join(variables)
|
|
+ return _ExtractImportantEnvironment(variables)
|
|
+
|
|
cpu_arg = "amd64"
|
|
if cpu != 'x64':
|
|
# x64 is default target CPU thus any other CPU requires a target set
|
|
diff --git build/vs_toolchain.py build/vs_toolchain.py
|
|
index 8bcba3e3f871dfe90e4e98c8141349cea9bb3720..5bb3d746e005e2e674cf2655930a024bafd0f8d6 100755
|
|
--- build/vs_toolchain.py
|
|
+++ build/vs_toolchain.py
|
|
@@ -145,9 +145,16 @@ def SetEnvironmentAndGetRuntimeDllDirs():
|
|
runtime_path = os.path.pathsep.join(vs_runtime_dll_dirs)
|
|
os.environ['PATH'] = runtime_path + os.path.pathsep + os.environ['PATH']
|
|
elif sys.platform == 'win32' and not depot_tools_win_toolchain:
|
|
+ has_override_path = True
|
|
if not 'GYP_MSVS_OVERRIDE_PATH' in os.environ:
|
|
+ has_override_path = False
|
|
os.environ['GYP_MSVS_OVERRIDE_PATH'] = DetectVisualStudioPath()
|
|
|
|
+ if has_override_path:
|
|
+ # Don't attempt to copy DLLs when using a custom toolchain.
|
|
+ # The DLLs should already be discoverable via the PATH env variable.
|
|
+ return None
|
|
+
|
|
# When using an installed toolchain these files aren't needed in the output
|
|
# directory in order to run binaries locally, but they are needed in order
|
|
# to create isolates or the mini_installer. Copying them to the output
|
|
@@ -240,6 +247,10 @@ def _CheckIfVersionInstalled(version):
|
|
|
|
def GetVisualStudioVersion():
|
|
"""Return best available version of Visual Studio."""
|
|
+ # Return the explicitly requested version, if any.
|
|
+ if 'GYP_MSVS_VERSION' in os.environ:
|
|
+ return os.environ['GYP_MSVS_VERSION']
|
|
+
|
|
supported_versions = list(MSVS_VERSIONS.keys())
|
|
|
|
# VS installed in depot_tools for Googlers
|