Commit Graph
125 Commits
Author SHA1 Message Date
PowerShell Team Bot e1b392b6ff Update .NET SDK version from 8.0.100-preview.2.23157.25 to 8.0.100-preview.3.23178.7 (#19381) 2023-04-18 15:24:51 -07:00
Aditya Patwardhan b58db8b8f7 Bump .NET to Preview 2 version (#19305) 2023-03-09 15:06:36 -08:00
Aditya Patwardhan 2d15e0c5b6 Update to .NET 8 preview 1 build (#19194) 2023-02-22 16:12:16 -08:00
CarloToso b85fe99f5a Use interpolated strings 2 (#18978) 2023-01-20 22:22:10 +05:00
Aditya Patwardhan de416dc831 Bump .NET SDK to version 7.0.101 (#18786) 2022-12-14 10:55:17 -08:00
Steve Lee 837482376e Replace msh in public API comment based documentation with PowerShell equivalent (#18483) 2022-11-08 08:27:52 +05:00
CarloToso 223d9a4d14 Small cleanup of the stub code (#18301) 2022-10-17 14:51:34 -07:00
MartinGC94 a7559e0987 Add output type attributes for Get-WinEvent (#17948) 2022-08-23 06:17:33 +00:00
Frode Flaten 5f4e100456 Use null propagation operator for windows build (#17795)
* Use null propagation in CimCmdlets

* Use null propagation in Diagnostics and Management

* ignore IDE0031 rule in ConsoleHost

* Use null propagation in WSMan.Management

* Use null propagation in SMA

* ignore IDE0031 for securityDescHandle

* cleanup after review
2022-07-29 10:34:09 -07:00
Patrick Meinecke b780a34ad1 Fix the definition of the PDH_COUNTER_INFO struct (#17779)
* Correct the struct `PDH_COUNTER_INFO`
Fixes #13829

* Make code factor happy
2022-07-27 13:36:39 -07:00
arfy slowy 55855fbe5d Fix spelling in XML docs (#15939) 2021-08-17 09:01:04 +05:00
xtqqczze 0f2f23f67a Enable IDE0049 PreferBuiltInOrFrameworkType (#14491) 2021-07-28 12:39:14 -07:00
8a3e02dcf7 get-counter issue with -computer parameter (#15166)
* get-counter issue fixed

* Update src/Microsoft.PowerShell.Commands.Diagnostics/GetCounterCommand.cs

Co-authored-by: Krishna Yalavarthi <kryalava@microsoft.com>
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
2021-04-12 14:16:31 -07:00
xtqqczze b7a431a442 Fix SA1504: All accessors should be single-line or multi-lin (#14241)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1504.md
2021-01-09 12:44:38 +05:00
xtqqczze 9d4665f32f Enable SA1003: Symbols should be spaced correctly (#14476)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1003.md
2020-12-23 21:21:26 +05:00
xtqqczze 0991ecf2d4 Fix RCS1139: Add summary element to documentation comment (#14442)
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1139.md
2020-12-22 08:44:30 +05:00
xtqqczze 1ab2c0c2bd Fix IDE0032: UseAutoProperty part 3 (#14443)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0032
2020-12-19 12:01:11 +05:00
xtqqczze 41ab20cce3 Mark applicable structs as readonly and use in-modifier (#13919) 2020-12-09 11:36:48 -08:00
xtqqczze d5b0264374 Use consistent spacing in xml documentation tags (#14231) 2020-11-25 22:58:52 +05:00
xtqqczze c7bdb24ff3 Mark local variable as const (#13217)
RCS1118: Mark local variable as const https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1118.md
2020-11-24 20:06:16 +05:00
xtqqczze 4ab1b90d08 Fix CA1822: Mark members as static part 2 (#14225)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
2020-11-24 12:05:34 +05:00
xtqqczze cba73e724f Enable SA1106: Code should not contain empty statements (#13964)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1106.md
2020-11-21 19:26:44 +05:00
xtqqczze 7e26eca03e Fix IDE0090: Simplify new expression part 1 (#14027)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0090
2020-11-20 17:36:53 +05:00
xtqqczze 4d2965af29 Autofix SA1518: The code must not contain extra blank lines at the end of the file (#13574) 2020-11-11 12:15:20 +05:00
xtqqczze 6b009c11e3 Remove unnecessary usings part 2 (#14017)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005
2020-11-10 08:15:04 +05:00
xtqqczze 45ffc2c6e5 Replace magic number with constant in PDH (#13536)
* Replace magic number with constant

* Remove useless assignment (codacy)
2020-11-05 10:09:38 +05:00
xtqqczze 52ecb6d18e Run dotnet-format to improve formatting of source code (#13503) 2020-11-04 11:13:56 -08:00
xtqqczze af8558b065 Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable (#13878)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834
2020-10-30 12:07:18 +05:00
xtqqczze ac9846bf40 Fix IDE0044: MakeFieldReadonly part 2 (#13885)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-10-30 11:58:48 +05:00
Dongbo Wang 10237bdeb3 Update PowerShell to build against dotnet 5.0-RC.1 (#13643) 2020-09-23 14:04:01 -07:00
xtqqczze 78d0d0e306 Use uint instead of long for PDH constants (#13502) 2020-08-27 10:27:24 -07:00
xtqqczze 16f0b74187 Cleanup: Remove redundant empty lines (#13404) 2020-08-25 11:29:26 -07:00
xtqqczze d8f8f0a8bc Fix comparison of value type object to null (#13285) 2020-08-10 14:56:14 -07:00
Dongbo Wang 4b9b0788ed Revert "Use is null syntax (#13277)" (#13322)
This reverts commit 6c03776d74.
2020-07-30 16:06:38 -07:00
xtqqczze 6c03776d74 Use is null syntax (#13277)
Replace `== null` with `is null`
2020-07-30 18:04:03 +05:00
xtqqczze 8901d2a509 Cleanup: use int instead of uint in places where it's more appropriate (#13141) 2020-07-13 07:10:57 -07:00
xtqqczze bd90f1921f Code performance fixes (#12956)
* RCS1080: Use 'Count/Length' property instead of 'Any' method

* RCS1077: Optimize LINQ method call

* RCS1235: Optimize method call
2020-06-25 11:30:40 +05:00
xtqqczze 0d5d017f0f Code redundancy fixes (#12916)
* Autofix `RCS1036: Remove redundant empty line`

* Autofix `RCS1037: Remove trailing white-space`

* Autofix `RCS1033: Remove redundant boolean literal`

* Autofix: `RCS1038: Remove empty statement`

* Autofix `RCS1041: Remove empty initializer`

* Autofix `RCS1097: Remove redundant 'ToString' call

* Autofix: `RCS1420: Operator is unnecessary`
2020-06-11 11:25:35 +05:00
xtqqczze 0d5b7f5e6f Add missing assessibility modifiers (#12820)
# PR Summary

Automated fix of [RCS1018](https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1018.md)

## PR Context

## PR Checklist

- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
    - Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
    - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
    - [x] None
    - **OR**
    - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
        - [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
    - [x] Not Applicable
    - **OR**
    - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
        - [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
    - [x] N/A or can only be tested interactively
    - **OR**
    - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
    - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    - **OR**
    - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
        - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
        - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
        - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-31 04:46:24 +00:00
xtqqczze 05cab7fa5a Formatting: Add empty line between declarations (#12824)
# PR Summary

Automated fixes:
* RCS0013: Add empty line between single-line declarations of different kind
* RCS010: Add empty line between declarations

## PR Context


## PR Checklist

- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
    - Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
    - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
    - [x] None
    - **OR**
    - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
        - [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
    - [x] Not Applicable
    - **OR**
    - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
        - [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
    - [x] N/A or can only be tested interactively
    - **OR**
    - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
    - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    - **OR**
    - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
        - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
        - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
        - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-29 04:56:33 +00:00
xtqqczze 056b9d7ca3 Formatting: remove duplicate semicolons (#12666) 2020-05-17 15:07:06 -07:00
Steve Lee b7cb335f03 Update copyright notice to latest guidance (#12190) 2020-03-24 11:08:37 -07:00
Ilya 60387f1ad3 Use Dictionary.TryAdd() where possible (#11767) 2020-02-06 12:49:45 -08:00
xtqqczze a34d0f3e80 Reformat code according to EditorConfig rules (#11681) 2020-01-31 14:56:22 -08:00
xtqqczze 70d9ed4d55 Remove Unicode BOM from text files (#11546) 2020-01-11 12:15:34 +05:00
David Smatlak 3923ca1728 Fixes FWLinks for PS7 online help documents (#11071) 2019-12-02 10:25:56 -08:00
Ilya c17d5a7a27 Review currentculture (#11044)
Replace StringComparison.CurrentCulture with StringComparison.Ordinal where it is used without the need.
2019-11-22 08:37:42 +05:00
Ilya d58a82ad19 Cleanup: use the built-in type alias (#10882) 2019-11-06 08:47:32 +05:00
Steve Lee 7ddfb825e4 Add back Get-Counter cmdlet for Windows (#10933) 2019-11-05 16:48:11 -08:00
Ilya be54be4162 Add limit check in Get-WinEvent (#10648)
ReadEvent() returns the error if our query contains number of logs more then 256.
So add the limit check and issue user-friendly error message.
2019-10-23 22:28:59 +05:00