spaette
d29f34b5c2
typos ( #19058 )
2023-01-30 09:48:00 -08:00
CarloToso
e815e57601
Use interpolated strings 6 ( #18983 )
2023-01-20 16:59:55 +05:00
Steve Lee
27b5a0632d
Add -ProgressAction common parameter ( #18887 )
2023-01-09 09:40:40 -08:00
Steve Lee
c740a07e10
Change public API mention of monad to PowerShell ( #18491 )
...
* Change public API mention of `monad` to PowerShell
* looks like I forgot to save changes in some files
2022-11-14 12:45:23 -05:00
Steve Lee
837482376e
Replace msh in public API comment based documentation with PowerShell equivalent ( #18483 )
2022-11-08 08:27:52 +05:00
Frode Flaten
4b4f1d144f
Use null propagation operator in /engine ( #17789 )
2022-07-29 09:06:07 +05:00
Dmitry Volodin
dc2e682f3a
Use null-coalescing assignment in /engine ( #17720 )
2022-07-25 22:11:29 +05:00
Dongbo Wang
a32700a1c1
Add clean block to script block as a peer to begin, process, and end to allow easy resource cleanup ( #15177 )
2021-10-11 14:49:09 -07:00
Dongbo Wang
e98a8c8601
Fix '-PipelineVariable' to set variable in the right scope ( #16199 )
2021-10-07 10:26:21 -07:00
Sean Wheeler
6d2feeee38
Change 'snippet' tag to 'code' tag in XML comments ( #16106 )
2021-09-15 15:42:13 -07:00
Dongbo Wang
403767d7f7
Fix a casting error when using $PSNativeCommandUsesErrorActionPreference ( #15993 )
2021-08-25 17:05:54 -07:00
Robert Holt
a4d14576b3
Make the native command error handling optionally honor ErrorActionPreference ( #15897 )
2021-08-24 15:27:22 -07:00
Steve Lee
cced56d75a
Make PS-Committee reviewed experimental features stable ( #15864 )
2021-08-09 14:01:57 -07:00
xtqqczze
883ca98dd7
Seal private classes ( #15725 )
...
* Seal private classes
* Fix CS0509
* Fix CS0628
2021-07-19 14:09:12 +05:00
Staffan Gustafsson
efdc500ba5
Annotate ThrowTerminatingError with DoesNotReturn attribute ( #15352 )
2021-05-06 09:23:34 -07:00
xtqqczze
b7a431a442
Fix SA1504: All accessors should be single-line or multi-lin ( #14241 )
...
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1504.md
2021-01-09 12:44:38 +05:00
Joel Sallow (/u/ta11ow)
16e2b62d78
Ensure -PipelineVariable is set for all output from script cmdlets ( #12766 )
2020-12-10 12:12:34 -08:00
xtqqczze
0d1ea73e59
Enable IDE0074: Use coalesce compound assignment ( #13396 )
...
* Autofix IDE0074: Use compound assignment
2020-11-25 17:37:01 +05:00
xtqqczze
c7bdb24ff3
Mark local variable as const ( #13217 )
...
RCS1118: Mark local variable as const https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1118.md
2020-11-24 20:06:16 +05:00
xtqqczze
cba73e724f
Enable SA1106: Code should not contain empty statements ( #13964 )
...
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1106.md
2020-11-21 19:26:44 +05:00
xtqqczze
99a49e0eab
Enable SA1131: Use readable conditions ( #14132 )
...
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1131.md
2020-11-20 17:26:46 +05:00
xtqqczze
76cef3b299
Fix RCS1221: Use pattern matching instead of combination of 'as' operator and null check ( #13333 )
...
* Autofix RCS1221: Use pattern matching instead of combination of 'as' operator and null check
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1221.md
* Restore stripped comments
2020-11-05 21:58:48 +05:00
xtqqczze
03a58c4186
Use is not syntax part 2 ( #13338 )
2020-11-05 10:23:50 +05:00
xtqqczze
03a0ef26e6
Fix RCS1098: Constant values should be on right side of comparisons ( #13833 )
...
* Fix RCS1098: Constant values should be on right side of comparisons
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1098.md
2020-11-05 09:13:12 +05:00
xtqqczze
4ed88dedbc
Fix IDE0044: MakeFieldReadonly part 12 ( #13967 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-05 08:36:23 +05:00
xtqqczze
152456d7a0
Add single blank line after copyright header ( #13486 )
2020-09-02 08:15:16 +05:00
Steve Lee
d67649c300
Fix $? to not be $false when native command writes to stderr ( #13395 )
2020-08-19 09:31:38 -07:00
Steve Lee
511858a267
Make $ErrorActionPreference not affect stderr output of native commands ( #13361 )
2020-08-07 14:19:17 -07:00
xtqqczze
4597b41396
Use is not syntax where appropriate and remove unnecessary parentheses ( #13323 )
2020-07-31 16:41:59 -07:00
Dongbo Wang
4b9b0788ed
Revert "Use is null syntax ( #13277 )" ( #13322 )
...
This reverts commit 6c03776d74 .
2020-07-30 16:06:38 -07:00
xtqqczze
6c03776d74
Use is null syntax ( #13277 )
...
Replace `== null` with `is null`
2020-07-30 18:04:03 +05:00
xtqqczze
2c18386d79
Avoid usage of do statement to create an infinite loop ( #13137 )
...
* Autofix RCS1063
2020-07-20 09:23:14 +05:00
xtqqczze
e93381e73e
Add readonly modifier to internal static members ( #11777 )
...
# PR Summary
* Add readonly modifier to internal static members.
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-31 05:10:22 +00:00
xtqqczze
05cab7fa5a
Formatting: Add empty line between declarations ( #12824 )
...
# PR Summary
Automated fixes:
* RCS0013: Add empty line between single-line declarations of different kind
* RCS010: Add empty line between declarations
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-29 04:56:33 +00:00
xtqqczze
9212aac0fa
Use nameof operator ( #12716 )
...
# PR Summary
Using *Roslynator Command Line Tool version 0.1.0.4*
* Fix RCS1015:
* `"argument"` → `nameof(argument)`
* `enum.ToString()` → `nameof(enum)`
[RCS1015.log](https://github.com/PowerShell/PowerShell/files/4646102/RCS1015.log )
## PR Context
<!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-19 18:57:52 +00:00
Steve Lee
b7cb335f03
Update copyright notice to latest guidance ( #12190 )
2020-03-24 11:08:37 -07:00
Ilya
d364278daf
Cleanup style in InitialSessionState.cs ( #10865 )
2019-11-09 11:02:27 +05:00
Steve Lee
26c380de6e
Fix command runtime so StopUpstreamCommandsException doesn't get populated in -ErrorVariable ( #10840 )
2019-10-22 16:38:32 -07:00
Kirk Munro
139cd942b2
Transition ActionPreference.Suspend enumeration value into a non-supported, reserved state, and remove restriction on using ActionPreference.Ignore in preference variables ( #10317 )
2019-09-07 23:45:36 +05:00
Kirk Munro
8b9f4124ce
Add support to ActionPreference.Break to break into debugger ( #8205 )
2019-08-23 10:34:10 -07:00
Ilya
74c87ab20b
Cleanup: Use EndsWith(char) and StartsWith(char) ( #9994 )
2019-06-25 11:02:31 -07:00
Staffan Gustafsson
42c289fc8e
Improve formatting performance by having better primitives on PSObject ( #8785 )
...
By not doing excessive amounts of extra work, formatting can be sped up quite significantly (about 8x faster).
The main change comes from adding new, more efficient, primitive to query an object for the existence of an instance member.
The formatting system has been checking for if an object has properties other than some decorated properties added by PS remoting, and it doesn't this by retrieving all properties which results in heavy allocations and wasted cycles.
By adding `GetFirstOrDefault` to `PSObject` and similar primitives to the underlying Adapters, we are able to return early, without having to get all properties back.
2019-03-20 18:43:52 -07:00
Ilya
759c4abde8
Use Type.EmptyTypes and Array.Empty<T>() to replace our custom code of the same functionality ( #9042 )
2019-03-09 17:53:31 -08:00
Joel Sallow (/u/ta11ow)
b23e835d2d
Rename private methods in MshCommandRuntime.cs ( #9074 )
...
* DoWriteObjects() -> DoWriteEnumeratedObject()
* _WriteObjectsSkipAllowCheck() -> _EnumerateAndWriteObjectSkipAllowCheck()
2019-03-08 19:28:39 +05:00
Ilya
d80154430d
Style: Change first char to upper in summary comments ( #8597 )
2019-01-09 13:07:40 -08:00
Ilya
233b54ed65
Style: Add a space after "//" in comments and remove unneeded comments after "}" ( #8576 )
2019-01-05 17:51:20 -08:00
Ilya
1be3f4cc0e
Style: Add the ending period to the XML document texts ( #8577 )
2019-01-05 15:40:24 -08:00
Ilya
dfd2f69369
Style: Change 'String.' to 'string.' ( #8568 )
2018-12-31 20:44:16 +05:00
Ilya
56569b9315
Style: Replace String.IsNullOrEmpty with string.IsNullOrEmpty ( #8557 )
2018-12-31 15:10:15 +05:00
Ilya
7207db6360
Style: Convert to upper first char in <param> and <exception> doc tags ( #8556 )
2018-12-29 08:25:49 +05:00