Steve Lee
|
a99ea2acd2
|
Enable ANSI formatting via $PSStyle and support suppressing ANSI output (#13758)
|
2020-12-11 10:33:57 -08:00 |
|
xtqqczze
|
18717c529b
|
Enable IDE0075: SimplifyConditionalExpression (#14078)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0075
|
2020-12-02 08:25:56 +05:00 |
|
xtqqczze
|
8d4869372e
|
Mark private members as static part 10 (#14235)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
|
2020-11-27 13:16:31 +05:00 |
|
xtqqczze
|
d5b0264374
|
Use consistent spacing in xml documentation tags (#14231)
|
2020-11-25 22:58:52 +05:00 |
|
xtqqczze
|
c7bdb24ff3
|
Mark local variable as const (#13217)
RCS1118: Mark local variable as const https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1118.md
|
2020-11-24 20:06:16 +05:00 |
|
xtqqczze
|
fa6caf957e
|
Use see keyword in documentation (#14220)
Fix [DOC104](https://github.com/DotNetAnalyzers/DocumentationAnalyzers/blob/master/docs/DOC104.md)
|
2020-11-24 09:35:46 +05:00 |
|
xtqqczze
|
cba73e724f
|
Enable SA1106: Code should not contain empty statements (#13964)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1106.md
|
2020-11-21 19:26:44 +05:00 |
|
xtqqczze
|
f14c76aab9
|
Enable SA1516: Elements should be separated by blank line (#14137)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1516.md
|
2020-11-20 16:11:36 +05:00 |
|
xtqqczze
|
9e285298c0
|
Enable IDE0031: Null check can be simplified (#13548)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0031
|
2020-11-20 11:42:51 +05:00 |
|
xtqqczze
|
4d2965af29
|
Autofix SA1518: The code must not contain extra blank lines at the end of the file (#13574)
|
2020-11-11 12:15:20 +05:00 |
|
Marcos Ramos
|
11d7587f9b
|
Fix nullable usage on displayDescriptionData_Wide (#13805)
|
2020-11-10 12:19:17 -08:00 |
|
Marcos Ramos
|
60a8fa3ec8
|
Fix nullable usage on displayDescriptionData_Table.cs (#13808)
|
2020-11-10 12:18:47 -08:00 |
|
xtqqczze
|
76be8f3ce5
|
Fix RCS1033: Remove redundant boolean literal part 1 (#13454)
* Remove redundant boolean literal
Autofix RCS1033: Remove redundant boolean literal
* revert changes in System.Management.Automation
|
2020-11-05 22:23:27 +05:00 |
|
xtqqczze
|
76cef3b299
|
Fix RCS1221: Use pattern matching instead of combination of 'as' operator and null check (#13333)
* Autofix RCS1221: Use pattern matching instead of combination of 'as' operator and null check
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1221.md
* Restore stripped comments
|
2020-11-05 21:58:48 +05:00 |
|
xtqqczze
|
03a58c4186
|
Use is not syntax part 2 (#13338)
|
2020-11-05 10:23:50 +05:00 |
|
xtqqczze
|
eaad6c2235
|
Fix accessor order (#13538)
* Fix Microsoft.PowerShell.Commands.Utility
* Fix System.Management.Automation
* Fix Microsoft.Management.Infrastructure.CimCmdlets
* Fix Microsoft.PowerShell.Commands.Management
* Fix Microsoft.WSMan.Management
|
2020-11-05 10:05:50 +05:00 |
|
xtqqczze
|
03a0ef26e6
|
Fix RCS1098: Constant values should be on right side of comparisons (#13833)
* Fix RCS1098: Constant values should be on right side of comparisons
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1098.md
|
2020-11-05 09:13:12 +05:00 |
|
xtqqczze
|
4595a22c64
|
Fix IDE0044: MakeFieldReadonly part 16 (#13971)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
|
2020-11-05 08:26:39 +05:00 |
|
xtqqczze
|
4b9f9dc457
|
Enable CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder (#13926)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1830
|
2020-11-02 08:46:40 +05:00 |
|
xtqqczze
|
2c1546cd47
|
Enable CA1836: Prefer IsEmpty over Count when available (#13877)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1836
|
2020-10-30 12:15:29 +05:00 |
|
xtqqczze
|
af8558b065
|
Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable (#13878)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834
|
2020-10-30 12:07:18 +05:00 |
|
Dongbo Wang
|
10237bdeb3
|
Update PowerShell to build against dotnet 5.0-RC.1 (#13643)
|
2020-09-23 14:04:01 -07:00 |
|
xtqqczze
|
859890374a
|
Use read-only auto-implemented properties (#13507)
* Autofix RCS1170: Use read-only auto-implemented property
|
2020-09-02 08:11:16 +05:00 |
|
xtqqczze
|
8f37cced70
|
Cleanup: remove duplicate words in comments (#13539)
|
2020-08-31 11:39:00 -07:00 |
|
xtqqczze
|
d8f8f0a8bc
|
Fix comparison of value type object to null (#13285)
|
2020-08-10 14:56:14 -07:00 |
|
Dongbo Wang
|
4b9b0788ed
|
Revert "Use is null syntax (#13277)" (#13322)
This reverts commit 6c03776d74.
|
2020-07-30 16:06:38 -07:00 |
|
xtqqczze
|
6c03776d74
|
Use is null syntax (#13277)
Replace `== null` with `is null`
|
2020-07-30 18:04:03 +05:00 |
|
xtqqczze
|
bd90f1921f
|
Code performance fixes (#12956)
* RCS1080: Use 'Count/Length' property instead of 'Any' method
* RCS1077: Optimize LINQ method call
* RCS1235: Optimize method call
|
2020-06-25 11:30:40 +05:00 |
|
Joel Sallow (/u/ta11ow)
|
02af121ca2
|
Fix issue in Select-Object where Hashtable members (e.g., Keys) cannot be used with -Property or -ExpandProperty (#11097)
|
2020-06-19 15:46:54 -07:00 |
|
xtqqczze
|
a15e5090e2
|
Use HashSet instead of Hashtable with null values (#12958)
|
2020-06-19 08:31:18 +05:00 |
|
xtqqczze
|
0d5d017f0f
|
Code redundancy fixes (#12916)
* Autofix `RCS1036: Remove redundant empty line`
* Autofix `RCS1037: Remove trailing white-space`
* Autofix `RCS1033: Remove redundant boolean literal`
* Autofix: `RCS1038: Remove empty statement`
* Autofix `RCS1041: Remove empty initializer`
* Autofix `RCS1097: Remove redundant 'ToString' call
* Autofix: `RCS1420: Operator is unnecessary`
|
2020-06-11 11:25:35 +05:00 |
|
xtqqczze
|
e93381e73e
|
Add readonly modifier to internal static members (#11777)
# PR Summary
* Add readonly modifier to internal static members.
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
|
2020-05-31 05:10:22 +00:00 |
|
xtqqczze
|
05cab7fa5a
|
Formatting: Add empty line between declarations (#12824)
# PR Summary
Automated fixes:
* RCS0013: Add empty line between single-line declarations of different kind
* RCS010: Add empty line between declarations
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
|
2020-05-29 04:56:33 +00:00 |
|
Ilya
|
c602f8272e
|
Remove extra line before formatting group (#12163)
|
2020-05-28 13:19:56 -07:00 |
|
xtqqczze
|
9212aac0fa
|
Use nameof operator (#12716)
# PR Summary
Using *Roslynator Command Line Tool version 0.1.0.4*
* Fix RCS1015:
* `"argument"` → `nameof(argument)`
* `enum.ToString()` → `nameof(enum)`
[RCS1015.log](https://github.com/PowerShell/PowerShell/files/4646102/RCS1015.log)
## PR Context
<!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
|
2020-05-19 18:57:52 +00:00 |
|
Sergey Vasin
|
79a483be34
|
Fix comments in Mshexpression.cs (#12711)
# PR Summary
Fix comments in Mshexpression.cs
## PR Context
Fix summary comments for ResolveNames methods in Mshexpression.cs.
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
|
2020-05-19 14:49:18 +00:00 |
|
xtqqczze
|
056b9d7ca3
|
Formatting: remove duplicate semicolons (#12666)
|
2020-05-17 15:07:06 -07:00 |
|
Steve Lee
|
f23be437af
|
Fix terms checker issues (#12189)
|
2020-03-24 11:38:45 -07:00 |
|
Steve Lee
|
b7cb335f03
|
Update copyright notice to latest guidance (#12190)
|
2020-03-24 11:08:37 -07:00 |
|
Ilya
|
b5d4739b2a
|
Use span-based overloads (#11884)
|
2020-03-18 18:38:55 +05:00 |
|
Steve Lee
|
a09855017f
|
Generate guid for FormatViewDefinition InstanceId if not provided (#11896)
|
2020-02-20 19:57:26 +05:00 |
|
Ilya
|
60387f1ad3
|
Use Dictionary.TryAdd() where possible (#11767)
|
2020-02-06 12:49:45 -08:00 |
|
Ilya
|
dfb5b047b1
|
Revert "Update formatter to not write newlines if content is empty (#11193)" (#11342)
This reverts commit 51d2523f5f.
|
2019-12-18 00:53:19 +05:00 |
|
Steve Lee
|
ee4eba5348
|
Update calculation of char width to respect CJK chars correctly (#11262)
|
2019-12-05 08:09:56 +05:00 |
|
Steve Lee
|
51d2523f5f
|
Update formatter to not write newlines if content is empty (#11193)
|
2019-12-02 10:51:02 -08:00 |
|
Ilya
|
d58a82ad19
|
Cleanup: use the built-in type alias (#10882)
|
2019-11-06 08:47:32 +05:00 |
|
Steve Lee
|
ca68d9dbc5
|
Add GraphicalHost assembly to enable Out-GridView, Show-Command, and Get-Help -ShowWindow (#10899)
|
2019-11-01 10:05:32 -07:00 |
|
Steve Lee
|
bf5956193f
|
Remove unused SourceLength remoting property causing formatting issues (#10765)
|
2019-10-12 22:10:10 +05:00 |
|
Steve Lee
|
77ddec1614
|
Add back newline for grouping with Format-Table and -Property (#10653)
|
2019-10-02 12:11:55 -07:00 |
|
Ilya
|
bd6fdae735
|
Cleanup: sort usings (#9490)
|
2019-04-30 10:25:11 +05:00 |
|