James Truher [MSFT]
|
c39d672560
|
Remove 4 assertions which cause debug build test runs to fail (#15963)
|
2021-08-22 10:49:07 -07:00 |
|
arfy slowy
|
55855fbe5d
|
Fix spelling in XML docs (#15939)
|
2021-08-17 09:01:04 +05:00 |
|
Aditya Patwardhan
|
6d09c6e40a
|
Fix CA1846 and CA1845 for using AsSpan instead of Substring (#15738)
|
2021-07-09 10:55:23 -07:00 |
|
xtqqczze
|
4c2d6dcfca
|
Make classes sealed (#15675)
Fix [RCS1225](https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1225.md)
|
2021-07-04 16:49:52 +05:00 |
|
Francesco Saltori
|
088eb6d039
|
Replace ProcessModule.FileName with Environment.ProcessPath and remove PSUtils.GetMainModule (#15012)
|
2021-06-03 12:32:55 -07:00 |
|
xtqqczze
|
4e073fdd3f
|
Avoid array allocations from GetDirectories/GetFiles. (#15167)
|
2021-04-15 08:16:26 +05:00 |
|
Ilya
|
91e7298fd8
|
Use static lambda keyword (#15154)
|
2021-04-12 12:44:05 -07:00 |
|
Aditya Patwardhan
|
b836de8223
|
Bump .NET framework to 6.0.0-preview.1 (#14719)
|
2021-02-08 17:13:33 -08:00 |
|
xtqqczze
|
9ea718f171
|
Enable CA2249: Consider using String.Contains instead of IndexOf (#14395)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249
|
2021-01-10 18:15:02 +05:00 |
|
xtqqczze
|
50fd950920
|
Enable CA1052: Static holder types should be Static or NotInheritable (#14483)
* Enable CA1052: Static holder types should be Static or NotInheritable
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/CA1052
* Fix SA1505
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1505.md
|
2021-01-08 22:53:11 +05:00 |
|
xtqqczze
|
9d4665f32f
|
Enable SA1003: Symbols should be spaced correctly (#14476)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1003.md
|
2020-12-23 21:21:26 +05:00 |
|
xtqqczze
|
5f3dd938b7
|
Use string.Contains(char) overload (#14368)
|
2020-12-19 20:00:51 +05:00 |
|
xtqqczze
|
e35668ca0a
|
Avoid array allocations from GetDirectories/GetFiles. (#14330)
|
2020-12-07 16:11:03 +05:00 |
|
xtqqczze
|
8d4869372e
|
Mark private members as static part 10 (#14235)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
|
2020-11-27 13:16:31 +05:00 |
|
xtqqczze
|
3c1261f90d
|
Enable SA1643: Destructor summary documentation should begin with standard text (#14236)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1643.md
|
2020-11-26 10:39:27 +05:00 |
|
xtqqczze
|
c7bdb24ff3
|
Mark local variable as const (#13217)
RCS1118: Mark local variable as const https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1118.md
|
2020-11-24 20:06:16 +05:00 |
|
xtqqczze
|
cba73e724f
|
Enable SA1106: Code should not contain empty statements (#13964)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1106.md
|
2020-11-21 19:26:44 +05:00 |
|
xtqqczze
|
99a49e0eab
|
Enable SA1131: Use readable conditions (#14132)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1131.md
|
2020-11-20 17:26:46 +05:00 |
|
xtqqczze
|
f14c76aab9
|
Enable SA1516: Elements should be separated by blank line (#14137)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1516.md
|
2020-11-20 16:11:36 +05:00 |
|
xtqqczze
|
9e285298c0
|
Enable IDE0031: Null check can be simplified (#13548)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0031
|
2020-11-20 11:42:51 +05:00 |
|
xtqqczze
|
1386d0054a
|
Remove LINQ Count method uses (#13545)
|
2020-11-11 09:39:59 -08:00 |
|
xtqqczze
|
4d2965af29
|
Autofix SA1518: The code must not contain extra blank lines at the end of the file (#13574)
|
2020-11-11 12:15:20 +05:00 |
|
xtqqczze
|
093edbb9a9
|
Make applicable private Guid fields readonly (#14000)
* Make applicable private Guid fields readonly
* Use in-modifier for passing a readonly Guid
|
2020-11-08 10:43:59 +05:00 |
|
xtqqczze
|
2e24380b8c
|
Fix CA1003: Use generic event handler instances (#13937)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1003
|
2020-11-07 16:30:19 +05:00 |
|
xtqqczze
|
76cef3b299
|
Fix RCS1221: Use pattern matching instead of combination of 'as' operator and null check (#13333)
* Autofix RCS1221: Use pattern matching instead of combination of 'as' operator and null check
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1221.md
* Restore stripped comments
|
2020-11-05 21:58:48 +05:00 |
|
xtqqczze
|
03a58c4186
|
Use is not syntax part 2 (#13338)
|
2020-11-05 10:23:50 +05:00 |
|
xtqqczze
|
eaad6c2235
|
Fix accessor order (#13538)
* Fix Microsoft.PowerShell.Commands.Utility
* Fix System.Management.Automation
* Fix Microsoft.Management.Infrastructure.CimCmdlets
* Fix Microsoft.PowerShell.Commands.Management
* Fix Microsoft.WSMan.Management
|
2020-11-05 10:05:50 +05:00 |
|
xtqqczze
|
3ba61069b8
|
Enable IDE0054: Use compound assignment (#13546)
* Autofix IDE0054
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0054-ide0074
|
2020-11-05 09:48:13 +05:00 |
|
xtqqczze
|
03a0ef26e6
|
Fix RCS1098: Constant values should be on right side of comparisons (#13833)
* Fix RCS1098: Constant values should be on right side of comparisons
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1098.md
|
2020-11-05 09:13:12 +05:00 |
|
xtqqczze
|
cc6ce4f66d
|
Fix IDE0044: MakeFieldReadonly part 14 (#13969)
|
2020-11-03 08:47:07 -08:00 |
|
xtqqczze
|
af8558b065
|
Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable (#13878)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834
|
2020-10-30 12:07:18 +05:00 |
|
Dongbo Wang
|
10237bdeb3
|
Update PowerShell to build against dotnet 5.0-RC.1 (#13643)
|
2020-09-23 14:04:01 -07:00 |
|
 
|
3beeea49af
|
Revert "Add the parameter -Paged to Get-Help to support paging (#13374)" (#13519)
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
|
2020-09-02 15:00:19 -07:00 |
|
xtqqczze
|
8f37cced70
|
Cleanup: remove duplicate words in comments (#13539)
|
2020-08-31 11:39:00 -07:00 |
|
Aditya Patwardhan
|
485ec44005
|
Add the parameter -Paged to Get-Help to support paging (#13374)
|
2020-08-11 15:51:00 -07:00 |
|
Thomas Nieto
|
46efd38ef5
|
Fix Get-Help not properly displaying if parameter supports wildcards (#13353)
|
2020-08-11 10:20:45 -07:00 |
|
xtqqczze
|
d8f8f0a8bc
|
Fix comparison of value type object to null (#13285)
|
2020-08-10 14:56:14 -07:00 |
|
Christopher Yeleighton
|
7ed43d9c16
|
HelpSystem: Improve the wording of inline comments (#13274)
|
2020-08-04 15:11:10 -07:00 |
|
xtqqczze
|
4597b41396
|
Use is not syntax where appropriate and remove unnecessary parentheses (#13323)
|
2020-07-31 16:41:59 -07:00 |
|
Dongbo Wang
|
4b9b0788ed
|
Revert "Use is null syntax (#13277)" (#13322)
This reverts commit 6c03776d74.
|
2020-07-30 16:06:38 -07:00 |
|
xtqqczze
|
6c03776d74
|
Use is null syntax (#13277)
Replace `== null` with `is null`
|
2020-07-30 18:04:03 +05:00 |
|
xtqqczze
|
bd90f1921f
|
Code performance fixes (#12956)
* RCS1080: Use 'Count/Length' property instead of 'Any' method
* RCS1077: Optimize LINQ method call
* RCS1235: Optimize method call
|
2020-06-25 11:30:40 +05:00 |
|
xtqqczze
|
a15e5090e2
|
Use HashSet instead of Hashtable with null values (#12958)
|
2020-06-19 08:31:18 +05:00 |
|
xtqqczze
|
58c371ca31
|
Fix RCS1114: Remove redundant delegate creation (#12917)
|
2020-06-11 14:01:01 +05:00 |
|
xtqqczze
|
0d5d017f0f
|
Code redundancy fixes (#12916)
* Autofix `RCS1036: Remove redundant empty line`
* Autofix `RCS1037: Remove trailing white-space`
* Autofix `RCS1033: Remove redundant boolean literal`
* Autofix: `RCS1038: Remove empty statement`
* Autofix `RCS1041: Remove empty initializer`
* Autofix `RCS1097: Remove redundant 'ToString' call
* Autofix: `RCS1420: Operator is unnecessary`
|
2020-06-11 11:25:35 +05:00 |
|
Aditya Patwardhan
|
5a42f453c6
|
Update the PowerShell modules to use the new Help URI (#12686)
|
2020-06-02 11:46:24 -07:00 |
|
xtqqczze
|
e93381e73e
|
Add readonly modifier to internal static members (#11777)
# PR Summary
* Add readonly modifier to internal static members.
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
|
2020-05-31 05:10:22 +00:00 |
|
xtqqczze
|
4e98011833
|
cleanup: Use coalesce expression (#12829)
|
2020-05-31 10:01:08 +05:00 |
|
xtqqczze
|
05cab7fa5a
|
Formatting: Add empty line between declarations (#12824)
# PR Summary
Automated fixes:
* RCS0013: Add empty line between single-line declarations of different kind
* RCS010: Add empty line between declarations
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
|
2020-05-29 04:56:33 +00:00 |
|
xtqqczze
|
9212aac0fa
|
Use nameof operator (#12716)
# PR Summary
Using *Roslynator Command Line Tool version 0.1.0.4*
* Fix RCS1015:
* `"argument"` → `nameof(argument)`
* `enum.ToString()` → `nameof(enum)`
[RCS1015.log](https://github.com/PowerShell/PowerShell/files/4646102/RCS1015.log)
## PR Context
<!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
|
2020-05-19 18:57:52 +00:00 |
|