xtqqczze
18717c529b
Enable IDE0075: SimplifyConditionalExpression ( #14078 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0075
2020-12-02 08:25:56 +05:00
xtqqczze
d5b0264374
Use consistent spacing in xml documentation tags ( #14231 )
2020-11-25 22:58:52 +05:00
xtqqczze
0d1ea73e59
Enable IDE0074: Use coalesce compound assignment ( #13396 )
...
* Autofix IDE0074: Use compound assignment
2020-11-25 17:37:01 +05:00
xtqqczze
c7bdb24ff3
Mark local variable as const ( #13217 )
...
RCS1118: Mark local variable as const https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1118.md
2020-11-24 20:06:16 +05:00
xtqqczze
94597deb39
Mark private members as static part 8 ( #14233 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
2020-11-24 15:12:11 +05:00
xtqqczze
fa6caf957e
Use see keyword in documentation ( #14220 )
...
Fix [DOC104](https://github.com/DotNetAnalyzers/DocumentationAnalyzers/blob/master/docs/DOC104.md )
2020-11-24 09:35:46 +05:00
xtqqczze
83688be8a4
Enable SA1002: Semicolons should be spaced correctly ( #14197 )
...
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1002.md
2020-11-21 19:30:59 +05:00
xtqqczze
cba73e724f
Enable SA1106: Code should not contain empty statements ( #13964 )
...
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1106.md
2020-11-21 19:26:44 +05:00
xtqqczze
99a49e0eab
Enable SA1131: Use readable conditions ( #14132 )
...
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1131.md
2020-11-20 17:26:46 +05:00
xtqqczze
f14c76aab9
Enable SA1516: Elements should be separated by blank line ( #14137 )
...
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1516.md
2020-11-20 16:11:36 +05:00
xtqqczze
9e285298c0
Enable IDE0031: Null check can be simplified ( #13548 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0031
2020-11-20 11:42:51 +05:00
xtqqczze
006fe4d2dd
Enable IDE0082: ConvertTypeOfToNameOf ( #14042 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0082
2020-11-16 19:56:07 +05:00
xtqqczze
b521b858ad
Fix RCS1049: Simplify boolean comparison ( #13994 )
...
* Fix RCS1049: Simplify boolean comparison
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1049.md
Related https://github.com/dotnet/runtime/pull/44564
2020-11-13 09:39:25 +05:00
xtqqczze
4d2965af29
Autofix SA1518: The code must not contain extra blank lines at the end of the file ( #13574 )
2020-11-11 12:15:20 +05:00
xtqqczze
093edbb9a9
Make applicable private Guid fields readonly ( #14000 )
...
* Make applicable private Guid fields readonly
* Use in-modifier for passing a readonly Guid
2020-11-08 10:43:59 +05:00
xtqqczze
d128fbc1a8
Fix IDE0044: MakeFieldReadonly part 11 ( #13966 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-07 16:36:04 +05:00
xtqqczze
d6727dcf1b
Simplify delegate creation ( #13578 )
...
* Autofix RCS1048
* Autofix RCS1021
2020-11-05 22:25:26 +05:00
xtqqczze
76cef3b299
Fix RCS1221: Use pattern matching instead of combination of 'as' operator and null check ( #13333 )
...
* Autofix RCS1221: Use pattern matching instead of combination of 'as' operator and null check
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1221.md
* Restore stripped comments
2020-11-05 21:58:48 +05:00
xtqqczze
03a58c4186
Use is not syntax part 2 ( #13338 )
2020-11-05 10:23:50 +05:00
xtqqczze
eaad6c2235
Fix accessor order ( #13538 )
...
* Fix Microsoft.PowerShell.Commands.Utility
* Fix System.Management.Automation
* Fix Microsoft.Management.Infrastructure.CimCmdlets
* Fix Microsoft.PowerShell.Commands.Management
* Fix Microsoft.WSMan.Management
2020-11-05 10:05:50 +05:00
xtqqczze
af8558b065
Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable ( #13878 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834
2020-10-30 12:07:18 +05:00
xtqqczze
20401c9583
Enable IDE1005: InvokeDelegateWithConditionalAccess ( #13911 )
...
* Enable IDE1005: InvokeDelegateWithConditionalAccess
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide1005
2020-10-28 22:35:51 +05:00
Dongbo Wang
10237bdeb3
Update PowerShell to build against dotnet 5.0-RC.1 ( #13643 )
2020-09-23 14:04:01 -07:00
xtqqczze
859890374a
Use read-only auto-implemented properties ( #13507 )
...
* Autofix RCS1170: Use read-only auto-implemented property
2020-09-02 08:11:16 +05:00
xtqqczze
16f0b74187
Cleanup: Remove redundant empty lines ( #13404 )
2020-08-25 11:29:26 -07:00
xtqqczze
d8f8f0a8bc
Fix comparison of value type object to null ( #13285 )
2020-08-10 14:56:14 -07:00
xtqqczze
4597b41396
Use is not syntax where appropriate and remove unnecessary parentheses ( #13323 )
2020-07-31 16:41:59 -07:00
Dongbo Wang
4b9b0788ed
Revert "Use is null syntax ( #13277 )" ( #13322 )
...
This reverts commit 6c03776d74 .
2020-07-30 16:06:38 -07:00
xtqqczze
6c03776d74
Use is null syntax ( #13277 )
...
Replace `== null` with `is null`
2020-07-30 18:04:03 +05:00
xtqqczze
58c371ca31
Fix RCS1114: Remove redundant delegate creation ( #12917 )
2020-06-11 14:01:01 +05:00
xtqqczze
0d5d017f0f
Code redundancy fixes ( #12916 )
...
* Autofix `RCS1036: Remove redundant empty line`
* Autofix `RCS1037: Remove trailing white-space`
* Autofix `RCS1033: Remove redundant boolean literal`
* Autofix: `RCS1038: Remove empty statement`
* Autofix `RCS1041: Remove empty initializer`
* Autofix `RCS1097: Remove redundant 'ToString' call
* Autofix: `RCS1420: Operator is unnecessary`
2020-06-11 11:25:35 +05:00
xtqqczze
05cab7fa5a
Formatting: Add empty line between declarations ( #12824 )
...
# PR Summary
Automated fixes:
* RCS0013: Add empty line between single-line declarations of different kind
* RCS010: Add empty line between declarations
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-29 04:56:33 +00:00
xtqqczze
9212aac0fa
Use nameof operator ( #12716 )
...
# PR Summary
Using *Roslynator Command Line Tool version 0.1.0.4*
* Fix RCS1015:
* `"argument"` → `nameof(argument)`
* `enum.ToString()` → `nameof(enum)`
[RCS1015.log](https://github.com/PowerShell/PowerShell/files/4646102/RCS1015.log )
## PR Context
<!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-19 18:57:52 +00:00
Steve Lee
f23be437af
Fix terms checker issues ( #12189 )
2020-03-24 11:38:45 -07:00
Steve Lee
b7cb335f03
Update copyright notice to latest guidance ( #12190 )
2020-03-24 11:08:37 -07:00
Ilya
b5d4739b2a
Use span-based overloads ( #11884 )
2020-03-18 18:38:55 +05:00
Paul Higinbotham
a5a97a5939
Fix Invoke-Command missing error on session termination. ( #11586 )
2020-02-05 15:27:57 -08:00
xtqqczze
a34d0f3e80
Reformat code according to EditorConfig rules ( #11681 )
2020-01-31 14:56:22 -08:00
Robert Holt
f0fe356553
Restore SetBreakpoints API ( #11622 )
...
* Restore SetBreakpoints API
* Remove default values in API methods
* Fix inheriting APIs
* Correct further comments
* Fix breakpoint API use issues
* Fix breakpoint API tests
2020-01-30 11:27:57 -08:00
Tyler James Leonhardt
ca202da643
Improvements in breakpoint APIs for remote scenarios ( #11312 )
2019-12-12 17:23:12 -08:00
Andrew
b218e6f6cc
Support using non-compatible Windows PowerShell modules in PowerShell Core ( #10973 )
2019-11-18 10:44:55 -08:00
Paul Higinbotham
41e289853c
Code clean up for PSSession class ( #11001 )
2019-11-07 13:52:03 -08:00
Ilya
9851b07b1d
Fix style issues ( #10998 )
2019-11-07 11:49:06 -08:00
Ilya
d58a82ad19
Cleanup: use the built-in type alias ( #10882 )
2019-11-06 08:47:32 +05:00
Robert Holt
96eb361af8
Reinstate debugging API lost in #10338 ( #10808 )
2019-10-30 14:46:55 -07:00
Kirk Munro
ee8e4e00e0
Remove WorkflowJobSourceAdapter reference ( #10326 )
2019-09-17 10:46:35 +05:00
Kirk Munro
cc0fed479a
Add APIs for breakpoint management in runspaces and enable attach to process without BreakAll for PSES ( #10338 )
2019-09-05 11:30:25 -07:00
Ilya
fbf4f6c11b
Replace ArrayList with List<T> ( #10333 )
2019-09-05 10:54:18 -07:00
James Truher [MSFT]
fe2cc6aca8
Additional Telemetry - Implementation of RFC0036 ( #10336 )
2019-08-15 16:13:53 -07:00
Ilya
973156d54a
Cleanup: ThreadAbortException is now in .Net Core 3.0 ( #10230 )
...
* Cleanup: ThreadAbortException is now in .Net Core 3.0
* Fix CodeFactor issue
* Remove ThreadAbortException
* Remove ThreadAbortException relared code
2019-08-01 10:37:55 +05:00