aphrody-labs/PowerShell
1
0 Fork 0
mirror of https://github.com/aphrody-labs/PowerShell.git synced 2026-10-17 12:45:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix HTTP status from 409 to 429 for WebCmdlets to get retry interval from Retry-After header. (#19622)

Browse Source
This commit is contained in:
mkht authored and GitHub committed 2023-05-08 15:57:27 -07:00
1 parent facbfd6a64
commit 9502931493
2 files changed
+65 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
+64
View File
@@ -2157,6 +2157,38 @@ Describe "Invoke-WebRequest tests" -Tags "Feature", "RequireAdminOnWindows" {
$jsonResult = $result.output.Content | ConvertFrom-Json
$jsonResult.SessionId | Should -BeExactly $sessionId
}
It "Invoke-WebRequest respects the Retry-After header value in 429 status" {
$Query = @{
statusCode = 429
reposnsephrase = 'Too Many Requests'
contenttype = 'application/json'
body = '{"message":"oops"}'
headers = '{"Retry-After":"1"}'
}
$uri = Get-WebListenerUrl -Test 'Response' -Query $Query
$verboseFile = Join-Path $TestDrive -ChildPath verbose.txt
$result = Invoke-WebRequest -Uri $uri -MaximumRetryCount 1 -RetryIntervalSec 3 -SkipHttpErrorCheck -Verbose 4>$verbosefile
$verboseFile | Should -FileContentMatch 'Retrying after interval of 1 seconds. Status code for previous attempt: TooManyRequests'
}
It "Invoke-WebRequest ignores the Retry-After header value NOT in 429 status" {
$Query = @{
statusCode = 409
reposnsephrase = 'Conflict'
contenttype = 'application/json'
body = '{"message":"oops"}'
headers = '{"Retry-After":"1"}'
}
$uri = Get-WebListenerUrl -Test 'Response' -Query $Query
$verboseFile = Join-Path $TestDrive -ChildPath verbose.txt
$result = Invoke-WebRequest -Uri $uri -MaximumRetryCount 1 -RetryIntervalSec 3 -SkipHttpErrorCheck -Verbose 4>$verbosefile
$verboseFile | Should -FileContentMatch 'Retrying after interval of 3 seconds. Status code for previous attempt: Conflict'
}
}
Context "Regex Parsing" {
@@ -4047,6 +4079,38 @@ Describe "Invoke-RestMethod tests" -Tags "Feature", "RequireAdminOnWindows" {
$result.output.failureResponsesSent | Should -Be 1
$result.output.sessionId | Should -BeExactly $sessionId
}
It "Invoke-RestMethod respects the Retry-After header value in 429 status" {
$Query = @{
statusCode = 429
reposnsephrase = 'Too Many Requests'
contenttype = 'application/json'
body = '{"message":"oops"}'
headers = '{"Retry-After":"1"}'
}
$uri = Get-WebListenerUrl -Test 'Response' -Query $Query
$verboseFile = Join-Path $TestDrive -ChildPath verbose.txt
$result = Invoke-RestMethod -Uri $uri -MaximumRetryCount 1 -RetryIntervalSec 3 -SkipHttpErrorCheck -Verbose 4>$verbosefile
$verboseFile | Should -FileContentMatch 'Retrying after interval of 1 seconds. Status code for previous attempt: TooManyRequests'
}
It "Invoke-RestMethod ignores the Retry-After header value NOT in 429 status" {
$Query = @{
statusCode = 409
reposnsephrase = 'Conflict'
contenttype = 'application/json'
body = '{"message":"oops"}'
headers = '{"Retry-After":"1"}'
}
$uri = Get-WebListenerUrl -Test 'Response' -Query $Query
$verboseFile = Join-Path $TestDrive -ChildPath verbose.txt
$result = Invoke-RestMethod -Uri $uri -MaximumRetryCount 1 -RetryIntervalSec 3 -SkipHttpErrorCheck -Verbose 4>$verbosefile
$verboseFile | Should -FileContentMatch 'Retrying after interval of 3 seconds. Status code for previous attempt: Conflict'
}
}
}