aphrody-labs/PowerShell
1
0 Fork 0
mirror of https://github.com/aphrody-labs/PowerShell.git synced 2026-10-18 05:05:36 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Static analysis: Fix usage of XmlReader to ensure XmlResolver is null (#4108)

Browse Source 
* the default XmlResolver will attempt to resolve external resources, recommendation is to explicitly set to null which
will raise exception if malicious xml attempts to cause xmlreader to access external resources

* added DTDProcessing and related to XmlReaderSettings
This commit is contained in:
Steve Lee authored and Mike Richmond committed 2017-07-06 09:09:57 -07:00
1 parent dda482eaac
commit 36eaab2809
8 files changed
+7 -21
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/Microsoft.PowerShell.Workflow.ServiceCore/ServiceCore/WorkflowCore/WorkflowRuntimeCompilation.cs
+1 -1
View File
@@ -135,7 +135,7 @@ namespace Microsoft.PowerShell.Workflow
{
project.AddItem("XamlAppDef", file);
XamlXmlReader reader = new XamlXmlReader(XmlReader.Create(file), new XamlSchemaContext());
XamlXmlReader reader = new XamlXmlReader(XmlReader.Create(file, new XmlReaderSettings { XmlResolver = null }), new XamlSchemaContext());
using (reader)
{
while (reader.Read())