From 15e4e8a6af2f120bbd1eef8607131d878677c0ad Mon Sep 17 00:00:00 2001
From: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
Date: Tue, 24 Nov 2020 20:30:42 +0000
Subject: [PATCH] Remove unnecessary finalizers (#14248)
---
.../commands/management/ContentCommandBase.cs | 8 --------
.../FormatAndOutput/OutGridView/OutGridViewCommand.cs | 8 --------
.../commands/utility/ShowCommand/ShowCommand.cs | 8 --------
.../commands/utility/Tee-Object.cs | 8 --------
.../engine/CommandProcessorBase.cs | 8 --------
src/System.Management.Automation/engine/EventManager.cs | 8 --------
.../engine/lang/scriptblock.cs | 8 --------
src/System.Management.Automation/engine/pipeline.cs | 8 --------
8 files changed, 64 deletions(-)
diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/ContentCommandBase.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/ContentCommandBase.cs
index b595c0195..583f12cc8 100644
--- a/src/Microsoft.PowerShell.Commands.Management/commands/management/ContentCommandBase.cs
+++ b/src/Microsoft.PowerShell.Commands.Management/commands/management/ContentCommandBase.cs
@@ -705,14 +705,6 @@ namespace Microsoft.PowerShell.Commands
GC.SuppressFinalize(this);
}
- ///
- /// Finalizer.
- ///
- ~ContentCommandBase()
- {
- Dispose(false);
- }
#endregion IDisposable
-
}
}
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/OutGridViewCommand.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/OutGridViewCommand.cs
index 96a06a710..f7cc20283 100644
--- a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/OutGridViewCommand.cs
+++ b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/OutGridViewCommand.cs
@@ -492,13 +492,5 @@ namespace Microsoft.PowerShell.Commands
this.Dispose(true);
GC.SuppressFinalize(this);
}
-
- ///
- /// Finalizer.
- ///
- ~OutGridViewCommand()
- {
- Dispose(false);
- }
}
}
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommand.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommand.cs
index d9556753f..6306b7913 100644
--- a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommand.cs
+++ b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommand.cs
@@ -63,14 +63,6 @@ namespace Microsoft.PowerShell.Commands
private object _commandViewModelObj;
#endregion
- ///
- /// Finalizes an instance of the ShowCommandCommand class.
- ///
- ~ShowCommandCommand()
- {
- this.Dispose(false);
- }
-
#region Input Cmdlet Parameter
///
/// Gets or sets the command name.
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs
index ec5b85917..78ca964d4 100644
--- a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs
+++ b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs
@@ -149,14 +149,6 @@ namespace Microsoft.PowerShell.Commands
GC.SuppressFinalize(this);
}
- ///
- /// Finalizer.
- ///
- ~TeeObjectCommand()
- {
- Dispose(false);
- }
-
#region private
private CommandWrapper _commandWrapper;
private bool _alreadyDisposed;
diff --git a/src/System.Management.Automation/engine/CommandProcessorBase.cs b/src/System.Management.Automation/engine/CommandProcessorBase.cs
index e42234099..6ab071146 100644
--- a/src/System.Management.Automation/engine/CommandProcessorBase.cs
+++ b/src/System.Management.Automation/engine/CommandProcessorBase.cs
@@ -957,14 +957,6 @@ namespace System.Management.Automation
_disposed = true;
}
- ///
- /// Finalizer for class CommandProcessorBase.
- ///
- ~CommandProcessorBase()
- {
- Dispose(false);
- }
-
#endregion IDispose
}
}
diff --git a/src/System.Management.Automation/engine/EventManager.cs b/src/System.Management.Automation/engine/EventManager.cs
index 94fc57ea0..8f13eecd0 100644
--- a/src/System.Management.Automation/engine/EventManager.cs
+++ b/src/System.Management.Automation/engine/EventManager.cs
@@ -1510,14 +1510,6 @@ namespace System.Management.Automation
ForwardEvent?.Invoke(this, e);
}
- ///
- /// Destructor for the EventManager class.
- ///
- ~PSLocalEventManager()
- {
- Dispose(false);
- }
-
///
/// Disposes the EventManager class.
///
diff --git a/src/System.Management.Automation/engine/lang/scriptblock.cs b/src/System.Management.Automation/engine/lang/scriptblock.cs
index 05aaa6c56..765809be3 100644
--- a/src/System.Management.Automation/engine/lang/scriptblock.cs
+++ b/src/System.Management.Automation/engine/lang/scriptblock.cs
@@ -1313,14 +1313,6 @@ namespace System.Management.Automation
_disposed = true;
}
- ///
- /// Finalizer for class SteppablePipeline.
- ///
- ~SteppablePipeline()
- {
- Dispose(false);
- }
-
#endregion IDispose
}
diff --git a/src/System.Management.Automation/engine/pipeline.cs b/src/System.Management.Automation/engine/pipeline.cs
index 17fe22bcf..00ea51f71 100644
--- a/src/System.Management.Automation/engine/pipeline.cs
+++ b/src/System.Management.Automation/engine/pipeline.cs
@@ -91,14 +91,6 @@ namespace System.Management.Automation.Internal
_disposed = true;
}
- ///
- /// Finalizer for class PipelineProcessor.
- ///
- ~PipelineProcessor()
- {
- Dispose(false);
- }
-
#endregion IDispose
#region Execution Logging