Change Import-PowerShellDataFile tag to CI and simplify tests

test/powershell/Modules/Microsoft.PowerShell.Utility/PowerShellData.tests.ps1

@@ -1,83 +1,63 @@
-Describe "Tests for the Import-PowerShellDataFile cmdlet" -Tags "Feature" {
+Describe "Tests for the Import-PowerShellDataFile cmdlet" -Tags "CI" {
 
     It "Validates error on a missing path" {
 
-        $foundError = ""
         try
         {
             Import-PowerShellDataFile -Path /SomeMissingDirectory -ErrorAction Stop
+            Throw "Execution OK"
         }
         catch
         {
-            $foundError = $_.FullyQualifiedErrorId
+            $_.FullyQualifiedErrorId | Should be "PathNotFound,Microsoft.PowerShell.Commands.ResolvePathCommand"
         }
-        
-        $foundError | Should be "PathNotFound,Microsoft.PowerShell.Commands.ResolvePathCommand"
     }
 
     It "Validates error on a directory" {
 
-        $foundError = ""
         try
         {
             Import-PowerShellDataFile ${TESTDRIVE} -ErrorAction Stop
+            Throw "Execution OK"
         }
         catch
         {
-            $foundError = $_.FullyQualifiedErrorId
+            $_.FullyQualifiedErrorId | Should be "CouldNotParseAsPowerShellDataFile,Import-PowerShellDataFile"
         }
         
-        $foundError | Should be "CouldNotParseAsPowerShellDataFile,Import-PowerShellDataFile"
     }
 
     It "Generates a good error on an insecure file" {
 
-        $path = New-TemporaryFile
+        $path = Setup -f insecure.psd1 -content '@{ Foo = Get-Process }' -pass
-        Set-Content $path '@{ Foo = Get-Process }'
-        
-        $foundError = ""
         try
         {
             Import-PowerShellDataFile $path -ErrorAction Stop
+            Throw "Execution OK"
         }
         catch
         {
-            $foundError = $_.FullyQualifiedErrorId
+            $_.FullyQualifiedErrorId | Should be "InvalidOperationException,Import-PowerShellDataFile"
         }
-        finally
-        {
-            Remove-Item $path
-        }
-        
-        $foundError | Should be "InvalidOperationException,Import-PowerShellDataFile"
     }
 
     It "Generates a good error on a file that isn't a PowerShell Data File (missing the hashtable root)" {
 
-        $path = New-TemporaryFile
+        $path = setup -f NotAPSDataFile -content '"Hello World"' -Pass
-        Set-Content $path '"Hello World"'
-        
-        $foundError = ""
         try
         {
             Import-PowerShellDataFile $path -ErrorAction Stop 
+            Throw "Execution OK"
         }
         catch
         {
-            $foundError = $_.FullyQualifiedErrorId
+            $_.FullyQualifiedErrorId | Should be "CouldNotParseAsPowerShellDataFileNoHashtableRoot,Import-PowerShellDataFile"
         }
-        finally
-        {
-            Remove-Item $path
-        }
-        
-        $foundError | Should be "CouldNotParseAsPowerShellDataFileNoHashtableRoot,Import-PowerShellDataFile"
     }
 
     It "Can parse a PowerShell Data File (detailed tests are in AST.SafeGetValue tests)" {
 
-        $path = New-TemporaryFile
+        $path = Setup -F gooddatafile -content '@{ "Hello" = "World" }' -pass
-        Set-Content $path '@{ "Hello" = "World" }'
         
         $result = Import-PowerShellDataFile $path -ErrorAction Stop
         $result.Hello | Should be "World"