72 Commits
Author SHA1 Message Date
Nikolche Kolev 48f1ab193b More E2E test fixes (#6962) 2025-11-24 11:56:11 -08:00
Andy Zivkovic ba112de7ee Make nullable enabled by default across entire repo (#6960) 2025-11-20 21:13:26 +10:30
Simon Cropp da0a2a7832 Remove un used members (#6721) 2025-09-30 13:50:05 -07:00
Andy Zivkovic 1ac8c5127c Remove unused VS extensibility APIs (#6536) 2025-07-12 05:49:46 +09:30
Nikolche Kolev d67fa5b69a E2E Test: Fix solution folder name comparison (#6106) 2024-10-18 16:29:56 +00:00
Kartheek Penagamuri 76148aa8c6 remove unused usings and sort existing ones (#5971) 2024-08-20 21:20:27 +00:00
Nikolche Kolev 5ce62f9774 Remove custom property usage for ProjectReference from all NuGet projects, simplify dependencies where appropriate (#4960) 2022-12-02 13:57:56 -08:00
Jeff Kluge 2407dd2541 Use Directory.Build.props/targets/rsp in NuGet.Client repo (#4880) 2022-11-09 09:37:10 -08:00
Heng Liu 5436dba7e3 Add embeded readme.md file for NuGet packages. (#4476) 2022-03-22 11:39:00 -07:00
Andy Zivkovic 3c5cea96aa Update Newtonsoft.Json to 13.0.1 (#4167) 2021-08-05 14:23:46 -07:00
Andy Zivkovic b0cfb1c58d Use VS SDK where possible (#4104) 2021-06-14 16:06:13 -07:00
Erik De Bonte 9f2da3906b Update to dev17 VSSDK 2021-06-05 04:45:14 -07:00
Andy Zivkovic acca708792 Mark IVsPackageInstallerServices as obsolete (#4038) 2021-05-06 14:04:40 -07:00
Damon Tivel c219b612c2 Update Visual Studio SDK to 16.9.x (#3792)
Resolve https://github.com/nuget/home/issues/10297
2021-01-05 07:11:41 -08:00
Srdjan JovčićandSrdjan Jovcic f51de2ce35 Asynchronize access to IVsHierarchy. (#3701)
* Asynchronize access to IVsHierarchy.

* Reverting changes to VsTemplateWizard.cs

* Reverting changes to VsFrameworkCompatibilityTests.cs

* Fixing build break.

* Fixing public API in InternalAPITestHook.

* ProjectType: Using HashSet instead of arrays.

* LegacyPackageReferenceRestoreUtilityTests: Avoid duplicate calls.

* Fix CpsPackageReferenceProjectProvider.cs after mismerge on rebase.

* Remove unused GetAllEnvDTEProjects method.

* Ensure OnEnvDTEProjectAdded/Renamed is executed in entirety before continuing.

* Fix whitespace.

Co-authored-by: Srdjan Jovcic <srdjanj@microsoft.com>
2020-10-29 09:21:44 -07:00
Srdjan JovčićandSrdjan Jovcic 44f1096f58 VsHierarchy refactoring (#3673)
* Move VsHierarchyUtility to same folder as VsHierarchyItem.

* Extract EnvDTE.Project helpers into separate file.

* Move Env.DTE helpers into IDE folder.

* Make helpers true extension methods.

* Use explicit types where warranted.

Co-authored-by: Srdjan Jovcic <srdjanj@microsoft.com>
2020-09-28 18:50:15 -07:00
Kat Marchán 65abcc61f7 automatic formatting (#3587)
Fixes: https://github.com/NuGet/Client.Engineering/issues/487
2020-08-26 15:08:11 -07:00
scoban e3c62df98b Update Visual Studio dependencies (#3431)
* Update Visual Studio dependencies
* Remove NU1605 suppressions from ServiceHub references
2020-06-08 14:38:15 -07:00
Nikolche Kolev 71b317e139 Add descriptions for every project (#3289) 2020-03-23 17:03:08 -07:00
Nikolche Kolev 176a07cc0c Add a VS Online Environments output window (#3296) 2020-03-23 17:02:49 -07:00
Nikolche Kolev 5433d816f7 Use Item update to manage the dependencies (#3271) 2020-03-05 18:49:24 -08:00
Nikolche Kolev ad45f12db5 Address VSTHRD010 and VSTHRD109 and create follow up for VSTHRD003 (#3176) 2020-01-13 12:30:12 -08:00
Nikolche Kolev fcdcfb4c87 Fix VSSDK004, VSSDK005 & VSSDK006 analyzer warnings (#3173) 2020-01-10 11:56:11 -08:00
Nikolche Kolev cb402b5a33 Update all the VS dependency packages (#3172) 2019-12-23 20:07:15 -08:00
Andy Zivkovic 117c4bd01e Validate Newtonsoft.Json version matches VS/.NET Core SDK version (#2880) 2019-06-11 13:02:37 -07:00
Nikolche Kolev 175cc81641 Cleanup dependency graph, remove NU1605 warnings (#2674) 2019-01-11 16:33:51 -08:00
Nikolche Kolev f7e4a189c8 Remove NuGet.Packaging.Core (#2670) 2019-01-07 22:37:56 -08:00
Nikolche Kolev c5dfc973dd Cleanup the VS dependency graph, make the product buildable in Dev16 (#2565)
* add targets to correctly embed interops

* remove 14.0 as it's included through Microsoft>VisualStudio.Shell.15.0

* remove 15.0 as it's only used in the APItest

* remove 15.3 design time

* use the correct version of the Microsoft.NuGet.targets

* fix experimental instance
2018-12-13 17:02:56 -08:00
Nikolche Kolev d89d1a12c4 Define target frameworks/project locations in the common props/targets rather than the csproj itself (#2533)
* extract most of the target framework defintions out of the csproj

* remove every target framework mention from the sdk based csproj

* Move old style csprojes to use the projectversion too

* use better variable names

* use the nugetcoresrc and nugetclientssrc variables
2018-11-18 17:33:17 -08:00
Ashish Jain ebe5d46589 Fixing dev16 build (#2531) 2018-11-16 11:13:05 -08:00
Patricio Beltran 1d25f30c3b Remove dev14 references in source code (#2341) 2018-11-14 15:31:01 -08:00
Ashish Jain f7eca8be30 Adding packages lock file into Legacy PackageReference project hierarchy (#2469)
Adding packages lock file into Legacy PackageReference project hierarchy
2018-10-17 17:21:34 -07:00
Nikolche Kolev 5aaced85e5 Make sure that BaseIntermediateOutputPath/MSbuildProjectExtensionsPath is modified before the SDK.props imports (#2157) 2018-04-12 16:32:20 -07:00
Zhi Li 5f3fd208c5 1. removed LSL endToEnd test
2. fixed one EndToEnd test
3. mark all responseFile test as windows only tests
2017-11-07 16:08:12 -08:00
Rohit Agrawal 79a745606a Improve E2E infra and adapt to VSTS (#1714)
* remove clearing recycle bin

* add logging for vso

* kill running instances of vs regardless

* do not fail if a test times out

* fix logging typo

* more powershell fixes

* re-enable uwp specific tests

* fix termination condition of tests

* change how test result file gets copied to CI machine

* breaking out of while loop and more logging

* fix path issue for results.html

* more fixes in termination condition

* diagnosing parsing errors for first two tests

* log currently running test and fix log.txt logging

* log to console from log.txt using currentTestId

* trying to fix initial logging issue with one line in realtimeresults

* remove unnecesary diag logging

* fix log formatting and add back write-error in case of failure

* fix count of tests and logging

* fix numbering of test and re-enable commented code

* count tests after all assemblies have been loaded

* adding try catch block

*  fix try-catch

* fix numbering for test case factory scenario

* changes to parsing realtimeresults

* first pass at junit xml results

* write out junit test result file

* implement missing API in InternalApiTestHook for project.json migrator

* fix logging test results duration to junit

* start copying log and results file to nuget drop share

* update UwpPackageRefClassLibrary template

* fix project.json migrator uwp e2e test

* fix uwp package ref test

* fix new-item cmdlet to create directory instead of file

* change where to output full log in build drop

* change name of uwpclasslibrary project template

* get screenshot if test times out

* get screenshot only iff running on CI

* fix uwp migrator project json test

* fix nit

* don't queue functional tests via rest api

* fix screen capture type not found exception

* add mono to path explicitly

* echo path in mono and mac and output version

* no need to add mono to path
2017-09-26 14:27:28 -07:00
Alex Panov e5d632d5ed No-op fix for init.ps1 execution (#1560)
* No-op fix for init.ps1 execution

Resolves NuGet/Home#5557.

Another issue preventing `init.ps1` execution related to no-op change.
Earlier PS host relied on dgspec hash comparison to trigger the new
`init.ps1` discovery and run. Now when the hash is not provided it needs
different mechanism for the restore event handling.

This PR changes the restore completed event to contain restore status
and updates the PS host to analyze the restore status before executing
`init.ps1` scripts.

* Fixed the bug. Added e2e tests.

* Fixed bugs. Applied feedback.

* Added missing package

* Add signkey for tool
2017-07-23 15:47:34 -07:00
Nikolche Kolev 2664e37a4c clean restore cache file on build clean in VS 2017-07-17 18:19:46 -07:00
Alex Panov 0d2b804db0 End-to-End tests for LSL scenarios (#1483)
Resolves NuGet/Home#5258.

Added tests for basic scenarios per each project model supporting LSL
mode: `packages.config`, `project.json`, `PackageRef`.

Updated E2E test infrastructure to support test extension cmdlets and
running "theories". Added ability to skip tests for specific VS version.
Also added missing templates for unit-test project and native C++ console application.

Addressed PR feedback
2017-06-14 11:06:17 -07:00
Alex Panov 7985322db4 Lightweight solution load: Merge feature branch (#1379)
* Lightweight solution load: Merge feature branch

This change summarizes feature work done to enable full support of LSL
in NuGet Package Manager.

Main concepts introduced

- `IVsProjectAdapter` - An abstraction layer over `EnvDTE.Project`.
Represents a virtual project object. It is aware of LSL mode and is
capable to force load project when it's needed. All occurances of DTE
project have been replaced with new adapter object.

- `INuGetProjectServices` - Collection of project services as building
blocks to access underlying project system functionality, such as
reference reader, build properties, project system capabilites, script host.

- `VsCoreProjectSystemService` - Implementation of project services for VS
  core project system (DTE).

- `VsLangProjectSystemService` - Implementation of project services for
  managed languages project system (VsLangProj80).

- `WorkspaceProjectServices` - Implementation of project services for
  deferred projects based on Workspace* API.

Notable refactorings
- Decommissioned `EnvDTEProjectAdapter` in favour of the new adapter.
- `LegacyCSProjPackageReferenceProject` =>
  `LegacyPackageReferenceProject`.
- `CpsPackageReferenceProject` => `NetCorePackageReferenceProject`
- Multiple renamings to avoid confusion betwen projects and project
  systems.

Resolves NuGet/Home#5180.

* Cumulative PR feedback plus bug fixes

* Applied recommended design changes

* [BUG 441140] An error dialog pop up when creating C# ASP.NET Sigle Page Application

Fixes internal bug 441140.
2017-05-26 17:50:49 -07:00
Alex Panov f9fa6b3ab4 Merge and re-arrange NuGet.Client projects (#1313)
2nd pass over NuGet.Client projects.
Resolves NuGet/Client.Engineering#28
---
Changed the dependency order of PM.VS and PM.UI projects. Moved shared
code into `NuGet.VisualStudio.Common` (former Facade). Normalized
namespaces across all of the projects. Split constants. Split
`EnvDTEProjectUtility`.

New dependency graph of NuGet.Client projects:
```
NuGet.VisualStudio.Common
+---NuGet.VisualStudio
+---NuGet.VisualStudio.Interop
+---NuGet.SolutionRestoreManager.Interop
|
+---NuGet.TeamFoundationServer
|
+---NuGet.PackageManagement.VisualStudio
    +---NuGet.VisualStudio.Implementation
    +---NuGet.PackageManagement.PowerShellCmdlets
    +---NuGet.SolutionRestoreManager
    |
    +---NuGet.PackageManagement.UI
        +---Options
        +---NuGet.Console
        +---NuGet.Tools
        +---NuGet.VisualStudio.Client
```
2017-04-12 14:36:36 -07:00
Ashish Jain (NUGET) 312c42823b Improve auto restore performance and also NuGet sln load time 2017-04-05 12:48:58 -07:00
Ankit Mishra 13b17f9b55 Adding SkipSigning property to common.targets to allow projects like API.Test to not get delay signed (#1289) 2017-04-05 12:47:19 -07:00
Justin Emgarten b0589b8981 Moving common targets/props under the build folder 2017-03-27 16:03:54 -07:00
Ankit Mishra 08f88384c2 Migrating projects to net core and merging client and core solutions 2017-03-27 14:13:09 -07:00
Rohit Agrawal 33d534d26f fix hang issues when uwp project migration fails (#1241) 2017-03-17 15:28:23 -07:00
Rohit Agrawal b6fac67380 add e2e test for uwp project.json migrator (#1236) 2017-03-14 12:55:37 -07:00
Alex Panov c8137fd629 Extension API to determine root of NuGet package (#1234)
* Extension API to determine root of NuGet package

Resolves NuGet/Home#4736.

Extension API to determine root of NuGet package containing a specified
file.

New API provided as evolution of earlier version of
`IVsPathContext` and `IVsPathContextProvider`. Methods were changed to
follow `TryGet...` pattern. Async was dropped from the extension API due
to its incompatibility with interop embeddable interface.

Reference matching is implemented through path segment search trie data
structure.

* Renamed interface method
2017-03-10 17:14:57 -08:00
Ankit Mishra 57ae888bba Fixing the test for Net Core Cache Update Event (#1165) 2017-02-02 13:10:16 -08:00
Ankit Mishra c5aed1015e Adding Synchronization between PM UI and NuGet Project SystemCache (#1152) 2017-01-31 14:39:46 -08:00
Joel Verhagen b968d83c0a Add IVs APIs to get the user package and fallback package folders (#1098)
Fix https://github.com/NuGet/Home/issues/3920
Fix https://github.com/NuGet/Home/issues/3974
2017-01-06 13:54:06 -08:00